On Thu, 2011-11-03 at 09:36 +0100, Cedric Le Goater wrote: > > Hi Greg, > > > > I successfully applied the patches, but the compilation fails with: > > > > /home/dlezcano/work/src/lxc/src/lxc/lxc_init.c:164: undefined reference > > to `lxc_error_set_and_log_siginfo' > > /home/dlezcano/work/src/lxc/src/lxc/lxc_init.c:193: undefined reference > > to `lxc_error_set_and_log_siginfo' > > I have a different behavior : > > /usr/bin/ld: cannot find -llxc > > Probably because you didn't cleanup your build directory ? Anyhow, here's > a fix to be applied on top of Greg's patchset. > > Signed-off-by: Cedric Le Goater <c...@fr.ibm.com> > --- > src/lxc/Makefile.am | 2 +- > src/lxc/lxc_init.c | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > Index: lxc.git/src/lxc/Makefile.am > =================================================================== > --- lxc.git.orig/src/lxc/Makefile.am > +++ lxc.git/src/lxc/Makefile.am > @@ -113,7 +113,7 @@ lxc_execute_SOURCES = lxc_execute.c > lxc_freeze_SOURCES = lxc_freeze.c > lxc_info_SOURCES = lxc_info.c > lxc_init_SOURCES = lxc_init.c > -lxc_init_LDADD = -lutil -lcap -llxc > +lxc_init_LDFLAGS = -lutil
Oops... I should refresh my automake skills. :P Daniel, I confirm this is the guilty line. I've updated my patch. Do you want me to repost ? > lxc_monitor_SOURCES = lxc_monitor.c > lxc_restart_SOURCES = lxc_restart.c > lxc_start_SOURCES = lxc_start.c > Index: lxc.git/src/lxc/lxc_init.c > =================================================================== > --- lxc.git.orig/src/lxc/lxc_init.c > +++ lxc.git/src/lxc/lxc_init.c > @@ -36,6 +36,7 @@ > #include <sys/signalfd.h> > #include <sys/socket.h> > #include <linux/limits.h> > +#include <pty.h> > Hmm... Look at my original post, <pty.h> is included between <utmp.h> and <stdio.h>. I guess you want to fix this warning: In function ‘handle_rexec_connect’: src/lxc/lxc_init.c:372:3: warning: implicit declaration of function ‘login_tty’ right ? For a reason I don't fully understand, src/lxc/pty.h gets included instead of /usr/include/pty.h... hence the warning. Cedric, do you have any clue about this ? > #include "arguments.h" > #include "log.h" > -- Gregory Kurz gk...@fr.ibm.com Software Engineer @ IBM/Meiosys http://www.ibm.com Tel +33 (0)534 638 479 Fax +33 (0)561 400 420 "Anarchy is about taking complete responsibility for yourself." Alan Moore. ------------------------------------------------------------------------------ RSA(R) Conference 2012 Save $700 by Nov 18 Register now http://p.sf.net/sfu/rsa-sfdev2dev1 _______________________________________________ Lxc-devel mailing list Lxc-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxc-devel
