On 11/27/2012 02:13 AM, Natanael Copa wrote:
> There is no reason to depend on bash for a single echo.
> 
> Signed-off-by: Natanael Copa <nc...@alpinelinux.org>

Applied to staging. Thanks.

As for whether to move that code to lxc-info, I don't think that'd be
the right thing to do as lxc-info is meant to retrieve information from
a container, not from the host.

However, I think it'd make sense to have the version exposed by the C
API so that we may be able to implement a consistent "--version" to all
LXC commands that'd return the lxc version number.
If we do that, then there won't be any need for lxc-version anymore.

> ---
> Changes v1 -> v2:
>  - add signed-off-by
> 
>  src/lxc/lxc-version.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/lxc/lxc-version.in b/src/lxc/lxc-version.in
> index 1bd055a..b6875da 100644
> --- a/src/lxc/lxc-version.in
> +++ b/src/lxc/lxc-version.in
> @@ -1,3 +1,3 @@
> -#!/bin/bash
> +#!/bin/sh
>  
>  echo "lxc version: @PACKAGE_VERSION@"
> 


-- 
Stéphane Graber
Ubuntu developer
http://www.ubuntu.com

Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel

Reply via email to