Quoting Dwight Engen (dwight.en...@oracle.com):
> On Wed, 29 May 2013 22:21:22 -0500
> Serge Hallyn <serge.hal...@ubuntu.com> wrote:
> 
> > And update the comment explaining the locking.
> > 
> > Also take memlock in want_daemonize.
> 
> Hi Serge, could you explain a bit what the locking is protecting about
> open/close? It looks like you are locking around just the open or

Ok, I was under the impression that some libcs still had open/close
not threadsafe.  Apparently I'm wrong about that.  So I think the
majority of this patch can be dropped.  The locking comment updates
should still go in, as should the remaining reference to c->privlock
which was converted here.

I'll also switch process_lock users to assuming it can't fail, and
make it die harder if the mutex actually fails.

Will post new patches.  Thanks!

> just the close, and not the whole open to close region so I'm a bit
> confused on what scenario the locks are protecting against.

-serge

------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel

Reply via email to