Quoting Michael H. Warfield (m...@wittsend.com):
> Woa!  Hold!  Time out.  Do not do this.
> 
> On Tue, 2013-08-13 at 16:36 +0900, Satoshi Matsumoto wrote: 
> > Configure the guest init based on whether the PID 1 process is systemd
> > or not.
> 
> > In the template for Fedora, currently the guest is configured based on
> > whether the /bin/systemd exists in the host or not.
> 
> No...  It should be based on if systemd exists in the guest or not.  If
> not, I (we) have a bug.  I thought that was under a chroot.  If not, I
> will check it and fix it.

The current code is testing for systemd on the host.  That's not right.
You're right that checking for the running systemd in the guest isn't
right either :)

So I'd say the thing to do is

...
> > diff --git a/templates/lxc-fedora.in b/templates/lxc-fedora.in
> > index 23728c6..36c3d21 100644
> > --- a/templates/lxc-fedora.in
> > +++ b/templates/lxc-fedora.in
> > @@ -567,7 +567,7 @@ if [ $? -ne 0 ]; then
> >      exit 1
> >  fi
> 
> > -type /bin/systemd >/dev/null 2>&1

replace that with checking for $rootfs/bin/systemd as
well as $rootfs/usr/bin/systemd?

-serge

------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead. 
Download for free and get started troubleshooting in minutes. 
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel

Reply via email to