Quoting Christian Seiler (christ...@iwakd.de):
> Hi Serge,
>
> >> + if (!extra_keep_store[i]) {
> >> + SYSERROR("failed to allocate
> >> memory for storing current "
> >> + "environment variable
> >> values that will be kept");
> >> + while (i > 0)
> >> +
> >> free(extra_keep_store[--i]);
> >> + free(extra_keep_store);
> >> + return -1;
> >
> > The freeing seems unnecessary as you're about to rexit(-1), right?
>
> in the current flow, yes. However, this function may be useful from
> other places where one does not exit if it fails, so I'd rather be a bit
> defensive in the programming style, if possible.
In that case should you also free if the clearenv() fails?
------------------------------------------------------------------------------
Get 100% visibility into Java/.NET code with AppDynamics Lite!
It's a free troubleshooting tool designed for production.
Get down to code-level detail for bottlenecks, with <2% overhead.
Download for free and get started troubleshooting in minutes.
http://pubads.g.doubleclick.net/gampad/clk?id=48897031&iu=/4140/ostg.clktrk
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel
