On Wed, Aug 12, 2015 at 11:06:02AM -0600, Tycho Andersen wrote: > On Wed, Aug 12, 2015 at 06:41:55PM +0200, Dietmar Maurer wrote: > > > ..and it's not bind mounted from the host, which is why it's not being > > > autodetected as a bind mount. When I start both trusty and wily > > > containers I don't see anything mounting tracefs, do you know what is > > > mounting it? > > > > No sorry, I have no idea currently. But I will try to find out ... > > Thanks. Are you on a wily host or a vivid host? Just reading up on > tracefs now, I think it shouldn't be too hard to patch criu to handle > it.
Ok, based on a quick read I think all we need to restore are the fs opts. The attach patch should do that; can you try it? I'd still like to know what's mounting tracefs, but I suspect it is some systemd thing :) Tycho
>From 6b2a672801950d972474a86fc29d05f9e6ad2fd6 Mon Sep 17 00:00:00 2001 From: Tycho Andersen <[email protected]> Date: Wed, 12 Aug 2015 11:17:12 -0600 Subject: [PATCH] c/r: enable tracefs tracefs is a new filesystem that can be mounted by users. Only the options and fs name need to be passed to restore the state, so we can use criu's auto fs feature. Signed-off-by: Tycho Andersen <[email protected]> --- src/lxc/criu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/lxc/criu.c b/src/lxc/criu.c index e939b37..bd6ecac 100644 --- a/src/lxc/criu.c +++ b/src/lxc/criu.c @@ -49,7 +49,7 @@ lxc_log_define(lxc_criu, lxc); void exec_criu(struct criu_opts *opts) { char **argv, log[PATH_MAX]; - int static_args = 20, argc = 0, i, ret; + int static_args = 22, argc = 0, i, ret; int netnr = 0; struct lxc_list *it; @@ -60,7 +60,7 @@ void exec_criu(struct criu_opts *opts) * --manage-cgroups action-script foo.sh -D $(directory) \ * -o $(directory)/$(action).log --ext-mount-map auto * --enable-external-sharing --enable-external-masters - * --enable-fs hugetlbfs + * --enable-fs hugetlbfs --enable-fs tracefs * +1 for final NULL */ if (strcmp(opts->action, "dump") == 0) { @@ -122,6 +122,8 @@ void exec_criu(struct criu_opts *opts) DECLARE_ARG("--enable-external-masters"); DECLARE_ARG("--enable-fs"); DECLARE_ARG("hugetlbfs"); + DECLARE_ARG("--enable-fs"); + DECLARE_ARG("tracefs"); DECLARE_ARG("-D"); DECLARE_ARG(opts->directory); DECLARE_ARG("-o"); -- 2.1.4
_______________________________________________ lxc-users mailing list [email protected] http://lists.linuxcontainers.org/listinfo/lxc-users
