Quoting Frederic Crozat (fcro...@suse.com):
> Le mardi 23 avril 2013 à 10:09 -0500, Serge Hallyn a écrit :
> > Quoting Frederic Crozat (fcro...@suse.com):
>
> > Thanks - clearly my patch needed some love :) Just a few comments below.
>
> hehe :)
> >
> > > +
> > > + /* check if directory exists, and create it otherwise */
> > > + if (access(path, F_OK)) {
> > > + ret = mkdir(path, 0755);
> > > + if (ret == -1 && errno == EEXIST) {
> >
> > Did you mean errno != EEXIST?
>
> I blindly copied code from lxc_one_cgroup_create (now
> create_lxcgroups :)
That has:
if (ret == -1 && errno != EEXIST) {
> > > @@ -384,6 +430,10 @@ static int lxc_one_cgroup_create(const c
> > > SYSERROR("Failed creating pathname for cgroup parent (%d)\n",
> > > ret);
> > > return -1;
> > > }
> > > +
> > > + if (enable_hierarchy(cgparent))
> > > + return -1;
> >
> > Hm, do we want to fail container start on that, or just log a warning?
>
> Hmm, probably log a warning (but if you can't create a file in the main
> top directory, you are probably very doomed IMHO ;)
You're right - you don't return -1 if the file doesn't exist, so what
you have is fine.
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
Lxc-users mailing list
Lxc-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-users
