Awesome! Your work is highly appreciated. Following are my opinions regarding to the issues.
On Tue, May 12, 2009 at 3:26 AM, Marty Jack <[email protected]> wrote: > It would appear that Xubuntu Jaunty is shipping gpicview rather than > ristretto, which would be the natural choice for an Xfce-based product. How > exciting for us. But it means that we should get things fixed before we have > unhappy users and support work. This is quite true. If they'll really ship it, we need to work on it heavily. > Bug: The code in rotate_and_save_jpeg_lossless that tries to do a rename > doesn't work if /tmp is on a different filesystem than the target directory. > I've changed it so the temporary file gets created in the target directory. Is saving a temporary file really needed? After reviewing that part, it seems that jpeglib requires FILE* to do input and output. Care must be taken here since it's possible that the destination dir is read-only. So, access should be tested, and a "Save as" dialog + error messages are needed if the user doesn't have write access to the destination dir. > Bug 2086316 is in the area of saving an unsupported format. I've added an > error message when this happens to replace a FIXME. The bug complains that > the file is deleted, but I haven't seen this happening. > > Bug 2019492 asks us to have the 'confirm save' be done even if 'auto save on > rotate' is set, and to change the default for 'auto save on rotate' to False. > I've done these changes, which I agree with, but not everyone may. The out > of the box behaviors should be set so that data isn't overwritten. > > Bug 2019485 asks us to do a confirm in all cases on the JPEG path. I've > refactored this so it does this properly. > > Bug 1922058 I can't reproduce. It seems like it would be in the window > manager, if anywhere. > > Feature 1914844 asks for a keyboard shortcut to do Quit. I've added Q as a > keyboard shortcut to quit, I've added popup menu items for Preferences and > Quit, and a toolbar item for Quit. Escape key can be used to close the window. > Feature 1909959 asks for animated GIFs, feature 2089496 asks for slideshow. > These would be a good future thing, but these are complex and would require > timers. They would improve feature parity with other image viewers. This is possible. GdkPixbufAnimation can be used for this. However, maybe we need to handle still image with this class, too, and treat them as animation with only one frame. Otherwise, things can be complicated. > In my opinion features 1926748 (preload), 1951001 (set wallpaper), 2032457 > (printing) should be ruled outside the scope of gpicview. Set wallpaper is possible. PCManFM supports pcmanfm --set-wall-paper. Nautilus listens to gconf. gconf-tool is for this. xfce4-desktop, I guess, uses settings from xfconf. Kde? For others, show an error message? Printing is not impossible with gtk+ print support + cairo and it can be a TODO item. A future improvement should be multi-threading image loading with GdkPixbufLoader. In this way the UI won't be locked during image loading, and the user can cancel its lodaing, and jump to next image easily. This can improve user experience. MT programming is complicated, and error-prone, though. A thumbnail list as sidebar will be good, but it's hard to implement. ------------------------------------------------------------------------------ The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your production scanning environment may not be a perfect world - but thanks to Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700 Series Scanner you'll get full speed at 300 dpi even with all image processing features enabled. http://p.sf.net/sfu/kodak-com _______________________________________________ Lxde-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lxde-list
