Il 22/10/2009 14:22, Christoph Wickert ha scritto: > Hi Andrea, > > sorry it took so long, your mail was buried in my inbox. :( > Unfortunately dogd already applied some of your changes. > > Correct me if I'm wrong here: It's not OpenSUSE specific but only the > OpenSUSE build service will use it. As I said previously: The spec > distributed in the upstream tarball should be generic and not > distro-specfic. Even if it's just a comment. Packages should never be > built as root, so we don't need this anyway. >
not exactly, but anyway if you really think that delete a comment that do affect in NO ways the build, just do it- > > We already had this discussions before (when you suggested LXDE should > use OBS) and I'm sorry to repeat myself: If we started with this, we > will end up in a large bunch of %if ... %else clauses. What if distro X, > Y and Z come up and demand the same modifications? > understood.. just use the default group > > Agreed, except for your comment: Instead of "archive" we should write: > "Source should be provided with full URL when there is a stable > release." > > The source should be > http://downloads.sourceforge.net/sourceforge/lxde/%{name}-%{version}.tar.gz > then (works for all LXDE components and can be accessed with wget or > alike) > agree > > First of all I didn't criticize that change, but as you may already have > guessed I don't really like it ether: > 1. Too much comments IMO. This is a spec but not a book. ;) such comments was there only to explain why i added such changes they was not supposed to be apply > 2. We should trust %configure. of course we should... infact i changed ./configure --prefix=/usr to %configure because as i wrote on comment, %configure already pass --prefix=/usr read it carefully :P > 3. Using %define is problematic, you should prefer %global where > possible. Remember your distro specific hacks "%if 0%suse_version ..." > Imagine we used configure inside of such a conditional. %define is only > valid till the end of that statement (%else or %endif), so it won't work > for the files section and the build would fail. > agree here > > /me still prefers a simple and straight forward spec > as you wish ;) > > What is the sense of letting autotools set all the dirs through > %configure if you set them afterwards with %makeinstall. Trust the > autotools to do the right thing or don't use them. > > For more on this topic please read > http://fedoraproject.org/wiki/Packaging/Guidelines#Why_the_.25makeinstall_macro_should_not_be_used > got it.. since for me that is the same, just use the fedora less problematic one. btw, that's why i NEVER figured out abot it: cat /usr/lib/rpm/suse_macros | grep %makeinstall %makeinstall make DESTDIR=%{?buildroot:%{buildroot}} install suse is just smarter ;) > Sure. :) IMO there is no need for including all these commented things > in the spec. It LXDM get's translated, we would need to ship a new > package anyway - with an updated spec included. > as sed, comments was there only to explain the reasons of the changes. since LXDM now provides translations, that is no more needed... actually that patch: http://sourceforge.net/tracker/?func=detail&aid=2883523&group_id=180858&atid=894871 should be apply > As long as the file was not modified, it will get replaced even if it is > %config(noreplace). And if it was modified, it was most likely modified > on purpose. > If you really think it should be overwritten, use %config without > noreplace, but the %config tag is important for rpm's --verify. > i agree about %config but without (noreplace) you? >> %config %{_sysconfdir}/lxdm/lxdm.conf >> >> should be >> >> %config(noreplace) %{_sysconfdir}/lxdm/lxdm.conf > > Agreed. > cool >> i love to exachange our toughts so we can both became better packagers. > > Ok, I if you have any questions, don't hesitate to ask. > > Regards, > Christoph > regards, Andrea ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Lxde-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lxde-list
