Hi Giuseppe,
Nice work!
I haven't looked at the code in much detail yet, but here are some
random comments:
- The "Select Keyboard Model" window is unsorted, which makes it
hard to search.
- I cannot find my currently listed Keyboard Model, "evdev". Should
it be in that list?
- The German and US flags seem to have different sizes. Is that on
purpose?
- When using text layout, and putting the mouse over the plugin, the
background becomes almost white, with white letters. This is very
difficult to read. (I guess this was already the case with the old
plugin?)
Some more:
On Sun, Jul 29, 2012 at 05:26:23PM +0200, Giuseppe Penone wrote:
> The source code is here
> http://code.google.com/p/giuspen-lxpanel-0-5-10/source/checkout
>
> I started my work cloning the 0.5.10 version of lxpanel,
A patch to the git repository [1] would be easier to handle, since all
the files added by the autotools generate a lot of noise. But it is ok
for now.
> the only changes that I made are to lxpanel-0.5.10/src/plugins/xkb/*
Actually, I saw a change outside that directory, too. Would be great if
you could point out if there are more.
> ...
> The flags are in lxpanel-0.5.10/src/plugins/xkb/flags/*.svg and are taken
> from xfce4-xkb-plugin.
Should give them proper credit in the AUTHORS file. I assume the license
is ok?
Cheers,
Henry
[1] git://lxde.git.sourceforge.net/gitroot/lxde/lxpanel
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Lxde-list mailing list
Lxde-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxde-list
