Hi Giuseppe, On Sun, Aug 12, 2012 at 08:40:05PM +0300, Giuseppe Penone wrote: > > You could also query the exact scale factor with a spin button. > > yes this would be simpler to implement and probably require less memory > but it would be not fast and simple as the radiobuttons. > for now I will go on with radiobuttons but if there will be the need > for more sizes I will turn to a spinbutton.
ok, makes sense. > ... > > xkb-plugin.c: Instead of 5 times on_radiobutton_flag_size_5_toggled() > > you could pass the flag_size in the p_data, preferably using > > GINT_TO_POINTER() and GPOINTER_TO_INT(), see > > http://developer.gnome.org/glib/2.32/glib-Type-Conversion-Macros.html > > But I am nitpicking. :) > > this is unfortunately not possible because I need to give the pointer > to the plugin in the data since that's not global, and there's no room > for a second parameter. Eh, don't know how I could have missed that. :) > ... > > Black text on dark background doesn't work too well. It would be nice to > > have that configurable. (Or is there a better way?) > > > > now I set the color taking it from the panel text color, it should be fine. > If you feel the need for custom colors anyway I can implement in future > versions. Thanks, I will test it when I have a bit more time. > > > And one bug: The plugin correctly identifies my keyboard layout as "de", > > but until it is configured the config dialog only shows "us" in the > > "Keyboard Layouts" section. > > > > It's not clear to me, you say that the plugin identifies the keyboard > layout but then it shows "us". > Maybe you mean that on the panel you have the correct indication "DE" > but the configuration dialog shows "US"? Yes! > If you can reproduce the problem, can you send me the output of > "setxkbmap -query" either before and after changing the configuration > through the plugin? Maybe this is a setxkbmap problem? Steps to reproduce: a. Remove the xkb plugin. Not sure if this is sufficient. Then: $ setxkbmap -query rules: evdev model: evdev layout: us But this is wrong. I definitely have a "de" layout set, with umlaut and everything working. b. Add the xkb plugin. In the panel it shows the German flag, but in the config the list of layouts only includes "us". setxkbmap -query is the same as above. Also, did you see bug ID 3556371, url here[1]? I have no opinion on it, but wanted to make you aware of it. Thanks! Henry [1] https://sourceforge.net/tracker/?func=detail&atid=894869&aid=3556371&group_id=180858 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
