Hello Andriy,
Thanks for reviewing my patch.
I have modified the patch based on your comments. The new version is
attached at this post: https://sourceforge.net/p/lxde/patches/474/#ccde. I
modified only taskbar_button_drag_drop(). Is the patch ok yet?
PS: I would reply sooner, but I did not get your email, because I was
unsubscribed from the mailing list. I have found that email in the list's
archive. I have subscribed again.
Cheers,
Vlad
From: Andrej N. Gritsenko <andrej@re...> - 2014-07-21 19:02:57
Hello!
>
> Vladimír Pýcha has written on Wednesday, 16 July, at 2:10:
> >I have submitted a new patch against the latest code in git repository of
> >lxpanel. It adds the ability to reorder buttons on taskbar by dragging
> them
> >with mouse. For details see https://sourceforge.net/p/lxde/patches/474/.
> >Somebody please check it in, if possible.
>
> Your taskbar_button_drag_drop() is incorrect. Read D&D specifications,
> please. It is invalid to call gdk_drag_status() on drag drop, but the
> callback should either call gtk_drag_finish() directly, or indirectly
> (query the drag data then finish in data-received callback). Therefore
> calling taskbar_button_drag_motion() from taskbar_button_drag_drop()
> should be never done.
>
> >Cheers,
> >Vlad
>
> With best regards,
> Andriy.
>
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Lxde-list mailing list
Lxde-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxde-list
