Hello Vadim! Случилось как-то (Пятница, 23 Декабрь, 0:07), я получил письмо:
>Some time ago, I sent to your e-mail a letter with asking for >implementing the new option for enabling/disabling square brackets >around the names of minimized windows. You didn't answer me, and I was >so angry that I decided to do it by myself (I'm not even programmer, so >it was very difficult for me). I'm terribly sorry that I missed your letter and never answered it, this year happen to be too much busy for me with new interesting job and a lot of things in my life happened. You did a respectable work, thank you very much for your contribution! >Here is the changed files in enclosed .zip file. Please, review it and >merge. You should send a diff file instead of copies of changed files, that way it is easier to review the changes. As for your changes - overall it looks fine, except for 2 places: 1) SETUP_TOGGLE_BUTTON(checkbutton_show_square_brackets, ...) shouldn't be used right away, it will crash if user didn't update ui file, so it should be done the same way it's done for checkbutton_use_smaller_icons instead. 2) I would rather avoid duplication of code in task_draw_label(), it's much better to just replace if (!tb->visible) with if (!tb->visible && tb->flags.show_square_brackets) and that will leave rest of code not duplicated and intact while still your change is done. Also I would note your implementation will eliminate square brackets not just for minimized windows but also for windows from other monitors as well, is that really what you wanted to do? If that is true, then option description should be corrected appropriately in the configuraion window. >P.S. Sorry for this zip file, I couldn't clone git >(https://git.lxde.org/gitweb/?p=lxde/lxpanel.git;a=summary) and make the >.patch file. Here is the terminal log: Thank you for a note, the person who can fix it, is notified now, let hope it will be fixed soon. With best regards, Andriy. ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today.http://sdm.link/intel _______________________________________________ Lxde-list mailing list Lxde-list@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/lxde-list
