Hi, recently started to use notifications extensively and found two (to 
me) annoying details:

1) The height of the notification panels is not fixed. It usually 
increases, but there are situations where they shrink too.

Example 1: there are a few visible/active notifications. When I close 
any of them the rest will grow a few pixels taller.

Example 2: I make the system volume higher/lower using a keyboard 
shortcut repeteadly. When the volume changes, first the notification 
grows, them the next time shrinks, then grows, etc.

To fix this I modified Notification::setValues() in notification.cpp. 
The last line of the function was:

     setMinimumHeight(qMax(rect().height(), childrenRect().height()));

which I replaced by:

     int h = qMax(rect().height(), childrenRect().height());
     setMinimumHeight(h);
     setMaximumHeight(h);

It works for me...

2) I find it tiring to have to aim at (tiny) the close button on the 
upper right corner of the notifications to be able to close them. I'd 
rather prefer that clicking in any part of the notification closes it.

To obtain this behavior I modified the Notification::mouseReleaseEvent() 
function. That function has a cicle in it that on certain conditions 
closes the notification, right? I don't really understand what it does 
but I simply replaced the whole cicle for a call to 
closeButton_clicked() and now I have it working the way I wanted:

void Notification::mouseReleaseEvent(QMouseEvent * event)
{
//    qDebug() << "CLICKED" << event;
     QString appName;
     QString windowTitle;

     if (m_actionWidget && m_actionWidget->hasDefaultAction())
     {
         emit actionTriggered(m_actionWidget->defaultAction());
         return;
     }

     closeButton_clicked();
}

This most probably isn't the right way to do it (the code I deleted 
surely had a purpose!), so I should I do it? What should I expect to 
fail with the above implementation?

Thanks in advance for any hints...
Mario

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Lxde-list mailing list
Lxde-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxde-list

Reply via email to