[Lxde-list] [PATCH 2/2] icon-grid-old.c: fix possible NULL-dereference.

[Mario J. Rugiero]

From: Mario Rugiero <mrugi...@gmail.com>

---
 src/icon-grid-old.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/icon-grid-old.c b/src/icon-grid-old.c
index 0212ce9..57afe22 100644
--- a/src/icon-grid-old.c
+++ b/src/icon-grid-old.c
@@ -409,16 +409,18 @@ extern void icon_grid_reorder_child(IconGrid * ig, 
GtkWidget * child, gint posit
             ig->child_list = ige;
         }
         else
-            {
+        {
             int local_position = position - 1;
             IconGridElement * ige_pred;
             for (
               ige_pred = ig->child_list;
               ((ige_pred != NULL) && (local_position > 0));
               local_position -= 1, ige_pred = ige_pred->flink) ;
-            ige->flink = ige_pred->flink;
-            ige_pred->flink = ige;
-            }
+           if (ige_pred != NULL) {
+              ige->flink = ige_pred->flink; // ige_pred can be NULL
+              ige_pred->flink = ige;
+           }
+        }
 
         /* Do a relayout. */
         if (ige->visible)
-- 
2.17.1



_______________________________________________
Lxde-list mailing list
Lxde-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxde-list