While I was checking the DJGPP code I have submitted, I have found certain warnings/issues that I have tried to fix. See patch below; it is only a suggestion.
Regards, Juan M. Guerrero 2017-06-05 Juan Manuel Guerrero <juan.guerr...@gmx.de> * src/GridText.c (ALLOC_IN_POOL): Fix warning: 'ptr' may be used uninitialized in this function [-Wmaybe-uninitialized]. src/HTML.c (HTML_start_element): Fix warning: comparison between pointer and zero character constant [-Wpointer-compare]. src/LYMainLoop.c (check_JUMP_param): Fix warning: comparison between pointer and zero character constant [-Wpointer-compare]. diff -aprNU5 lynx2.8.9dev.14.orig/src/GridText.c lynx2.8.9dev.14/src/GridText.c --- lynx2.8.9dev.14.orig/src/GridText.c 2017-02-11 00:50:00 +0000 +++ lynx2.8.9dev.14/src/GridText.c 2017-06-05 20:37:10 +0000 @@ -238,11 +238,11 @@ There are 3 functions - POOL_NEW, POOL_F * Updates 'poolptr' if necessary. */ static void *ALLOC_IN_POOL(HTPool ** ppoolptr, unsigned request) { HTPool *pool = *ppoolptr; - pool_data *ptr; + pool_data *ptr = NULL; unsigned n; unsigned j; if (!pool) { outofmem(__FILE__, "ALLOC_IN_POOL"); diff -aprNU5 lynx2.8.9dev.14.orig/src/HTML.c lynx2.8.9dev.14/src/HTML.c --- lynx2.8.9dev.14.orig/src/HTML.c 2017-04-30 18:45:06 +0000 +++ lynx2.8.9dev.14/src/HTML.c 2017-06-05 20:44:26 +0000 @@ -3709,11 +3709,11 @@ static int HTML_start_element(HTStructur non_empty(value[HTML_OBJECT_TITLE])) { StrAllocCopy(me->object_title, value[HTML_OBJECT_TITLE]); TRANSLATE_AND_UNESCAPE_ENTITIES(&me->object_title, TRUE, FALSE); LYTrimHead(me->object_title); LYTrimTail(me->object_title); - if (me->object_title == '\0') { + if (*me->object_title == '\0') { FREE(me->object_title); } } if (present[HTML_OBJECT_DATA] && non_empty(value[HTML_OBJECT_DATA])) { @@ -3727,22 +3727,22 @@ static int HTML_start_element(HTStructur non_empty(value[HTML_OBJECT_TYPE])) { StrAllocCopy(me->object_type, value[HTML_OBJECT_TYPE]); TRANSLATE_AND_UNESCAPE_ENTITIES(&me->object_type, TRUE, FALSE); LYTrimHead(me->object_type); LYTrimTail(me->object_type); - if (me->object_type == '\0') { + if (*me->object_type == '\0') { FREE(me->object_type); } } if (present[HTML_OBJECT_CLASSID] && non_empty(value[HTML_OBJECT_CLASSID])) { StrAllocCopy(me->object_classid, value[HTML_OBJECT_CLASSID]); TRANSLATE_AND_UNESCAPE_ENTITIES(&me->object_classid, TRUE, FALSE); LYTrimHead(me->object_classid); LYTrimTail(me->object_classid); - if (me->object_classid == '\0') { + if (*me->object_classid == '\0') { FREE(me->object_classid); } } if (present[HTML_OBJECT_CODEBASE] && non_empty(value[HTML_OBJECT_CODEBASE])) { @@ -3760,21 +3760,21 @@ static int HTML_start_element(HTStructur TRANSLATE_AND_UNESCAPE_ENTITIES(&me->object_codetype, TRUE, FALSE); LYTrimHead(me->object_codetype); LYTrimTail(me->object_codetype); - if (me->object_codetype == '\0') { + if (*me->object_codetype == '\0') { FREE(me->object_codetype); } } if (present[HTML_OBJECT_NAME] && non_empty(value[HTML_OBJECT_NAME])) { StrAllocCopy(me->object_name, value[HTML_OBJECT_NAME]); TRANSLATE_AND_UNESCAPE_ENTITIES(&me->object_name, TRUE, FALSE); LYTrimHead(me->object_name); LYTrimTail(me->object_name); - if (me->object_name == '\0') { + if (*me->object_name == '\0') { FREE(me->object_name); } } } /* @@ -5065,11 +5065,11 @@ static int HTML_start_element(HTStructur if (present && present[HTML_TEXTAREA_ID] && non_empty(value[HTML_TEXTAREA_ID])) { StrAllocCopy(id_string, value[HTML_TEXTAREA_ID]); TRANSLATE_AND_UNESCAPE_TO_STD(&id_string); - if ((id_string != '\0') && + if ((*id_string != '\0') && (ID_A = HTAnchor_findChildAndLink(me->node_anchor, /* Parent */ id_string, /* Tag */ NULL, /* Addresss */ (HTLinkType *) 0))) { /* Type */ HText_beginAnchor(me->text, me->inUnderline, ID_A); diff -aprNU5 lynx2.8.9dev.14.orig/src/LYMainLoop.c lynx2.8.9dev.14/src/LYMainLoop.c --- lynx2.8.9dev.14.orig/src/LYMainLoop.c 2016-11-24 19:50:02 +0000 +++ lynx2.8.9dev.14/src/LYMainLoop.c 2017-06-05 20:37:10 +0000 @@ -3584,11 +3584,11 @@ static BOOLEAN check_JUMP_param(char **u * cancelled via ^G */ HTInfoMsg(CANCELLED); code = FALSE; break; - } else if ((encoded = urlencode(input->str)) != '\0') { + } else if (*(encoded = urlencode(input->str)) != '\0') { int subs_at = (int) (subs - result); int fill_in = (int) strlen(encoded) - 2; size_t have = strlen(result); size_t want = strlen(encoded) + have - 1; int n; _______________________________________________ Lynx-dev mailing list Lynx-dev@nongnu.org https://lists.nongnu.org/mailman/listinfo/lynx-dev