In a recent note, Thomas Dickey said: > Date: Thu, 8 Nov 2001 16:45:36 -0500 > > yes - I thought about your change to simply disable multibyte characters, > and it seemed that the real problem is that lynx was incorrectly deciding > that your data was some CJK flavor - we should fix that. But I also read > up on the multibyte stuff and as far as I can tell, none would have > embedded nulls, so I chose that solution. > Probably a good idea in even the ASCII case, since it may prevent a SIGSEV on invalid data which spoofs CJK.
But I suspect EBCDIC is highly likely to spoof CJK, and I haven't the resources to do the coding to support multibyte characters on OS/390. So I'm resubmitting my patch to disable multibyte processing if NOT_ASCII since this may affect far more than LYLowerCase. I've tamed the logic slightly, if that makes it more palatable. :-) Thanks, gil -- StorageTek INFORMATION made POWERFUL
%%% Created Thu Nov 8 17:53:02 MST 2001 by target lynx.patch. %%% diff -bru orig/lynx2-8-5/userdefs.h lynx2-8-5/userdefs.h --- orig/lynx2-8-5/userdefs.h Sat Oct 6 16:02:28 2001 +++ lynx2-8-5/userdefs.h Thu Nov 8 16:42:47 2001 @@ -30,6 +30,13 @@ #ifndef USERDEFS_H #define USERDEFS_H +/******************************************************************* + * Insure definition of NOT_ASCII, etc. precedes use below. + */ +#ifndef HTUTILS_H +#include <HTUtils.h> +#endif + #ifdef HAVE_CONFIG_H #include <lynx_cfg.h> #endif @@ -1458,12 +1465,18 @@ /***************************** + * I have not ported multibyte support for EBCDIC. In fact, some multibyte + * code in LYLowerCase() crashes on EBCDIC strings. -- gil + */ +#if ! defined(NOT_ASCII) +/***************************** * SUPPORT_MULTIBYTE_EDIT provides better support of CJK characters to * Lynx's Line Editor. JIS X0201 Kana is partially supported. The * reason why I didn't support it fully is I think supporting it is not * required so much and I don't have an environment to test it. - TH */ #define SUPPORT_MULTIBYTE_EDIT +#endif /* ! defined(NOT_ASCII) */ /***************************** * SUPPORT_CHDIR provides CD command (bound to 'C' by default). It allows
