Il 05/03/2011 17:58, Andre Poenitz ha scritto:
On Sat, Mar 05, 2011 at 02:45:39PM +0100, [email protected] wrote:
Author: kuemmel
Date: Sat Mar  5 14:45:39 2011
New Revision: 37859
URL: http://www.lyx.org/trac/changeset/37859

Log:
compile. TODO: review default parameter for replace_all

Modified:
    lyx-devel/trunk/src/frontends/qt4/FindAndReplace.h

Modified: lyx-devel/trunk/src/frontends/qt4/FindAndReplace.h
==============================================================================
--- lyx-devel/trunk/src/frontends/qt4/FindAndReplace.h  Sat Mar  5 12:10:35 
2011        (r37858)
+++ lyx-devel/trunk/src/frontends/qt4/FindAndReplace.h  Sat Mar  5 14:45:39 
2011        (r37859)
@@ -53,10 +53,14 @@
        );

        /// Perform the scope-related buffer switch while searching
-       void findAndReplaceScope(FindAndReplaceOptions&  opt);
+       bool findAndReplaceScope(FindAndReplaceOptions&  opt, bool replace_all);

        /// Collect options from the GUI elements, then perform the search
-       void findAndReplace(bool backwards, bool replace);
+       bool findAndReplace(bool backwards, bool replace, bool replace_all = 
false);
+
+       bool findAndReplace(bool casesensitive, bool matchword, bool backwards,
+               bool expandmacros, bool ignoreformat, bool replace,
+               bool keep_case, bool replace_all);
Shouldn't that be some kind of parameter stucture, instead of eight
booleans?
That's the main reason for which I have a FIXME somewhere about merging a couple of these methods together. I'll do some refactoring of the code when I have time...

    T.

Reply via email to