Op 15-3-2012 12:20, Vincent van Ravesteijn schreef:
Op 15-3-2012 2:29, [email protected] schreef:
Author: Uwe Stöhr<[email protected]>
Date: Thu, 15 Mar 2012 02:29:47 +0100
New Commit: 7d200f302d4dd06fe7b595ea19b4154bd9a8e530
URL: http://git.lyx.org/?p=lyx.git;a=commit;h=7d200f302d4dd06fe7b595ea19b4154bd9a8e530

Log:
GuiTabular.cpp: fix bug #8084

        // apply the column alignment
-       setHAlign(param_str);
+ // multirows inherit the alignment from the column; if a column width + // is set, multicolumns are always left-aligned so that in this case
+       // its alignment must not be applied (see bug #8084)
+       if (!(multirowCB->isChecked() && width != "0pt"))
+               setHAlign(param_str);

I guess the word 'multicolumns' is a typo here.

Shouldn't the GUI also disable the setting for halign if it is ignored ?

I think I would prefer:

bool const fixed_width_multirow = multirowCB->isChecked() && width != "0pt";
if (!fixed_width_multirow)
    setHAlign(param_str);

Also, this doesn't work in the GUI completely right. If I set a column with a multirow to horizontal align "Center". Then I enter a fixed width in the multirow, the alignment in LyX is still Centered. Both in the Table Settings dialog as in the main screen.

Vincent

Reply via email to