2015-05-17 1:46 GMT+02:00 Uwe Stöhr>:
> commit 8dd217c983976714b9f775ba119c62d8d180913f
> Author: Uwe Stöhr <[email protected]>
> Date: Sun May 17 01:45:56 2015 +0200
>
> GuiBox.cpp: fix bug introduced by [bec3f7bc/lyxgit]
>
> There were now 2 entries named "none" in backgroundcolorCO
>
> - delete the fixmes; the LateX name is used as parameter to save
> unnecessary conversions for the LateX output; please ask me before adding
> fixmes
>
But don't we use LyX names in LyX files consistently, and LaTeX names only
in the LaTeX output?
>
> diff --git a/src/frontends/qt4/GuiBox.cpp b/src/frontends/qt4/GuiBox.cpp
> index ecc3746..da2abe8 100644
> --- a/src/frontends/qt4/GuiBox.cpp
> +++ b/src/frontends/qt4/GuiBox.cpp
> @@ -242,7 +242,7 @@ void GuiBox::on_frameColorCO_currentIndexChanged(int
> index)
> backgroundColorCO->removeItem(n);
> }
> } else {
> - if (backgroundColorCO->findData("none") == -1)
> + if (backgroundColorCO->count() == color_codes_.count() - 1)
>
This should not be necessary. We check if none is in the combo via the code
you replaced.
Please tell me how to reproduce the problem with my code.
Jürgen