commit 7065406eca46572f45a86b654a5a6eb706214a4c
Author: Jean-Marc <[email protected]>
Date:   Sat Sep 12 18:33:17 2015 +0200

    image_ready is false at this point
    
    Coverity issue 23299.

diff --git a/src/insets/RenderGraphic.cpp b/src/insets/RenderGraphic.cpp
index a9342cc..48b41e2 100644
--- a/src/insets/RenderGraphic.cpp
+++ b/src/insets/RenderGraphic.cpp
@@ -142,7 +142,7 @@ void RenderGraphic::metrics(MetricsInfo & mi, Dimension & 
dim) const
                        loader_.startMonitoring();
        }
 
-       bool image_ready = displayGraphic(params_) && readyToDisplay(loader_);
+       bool const image_ready = displayGraphic(params_) && 
readyToDisplay(loader_);
        if (image_ready) {
                dim.wid = loader_.image()->width() + 2 * 
Inset::TEXT_TO_INSET_OFFSET;
                dim.asc = loader_.image()->height();
@@ -150,7 +150,7 @@ void RenderGraphic::metrics(MetricsInfo & mi, Dimension & 
dim) const
                return;
        }
 
-       dim.asc = image_ready ? loader_.image()->height() : 50;
+       dim.asc = 50;
        dim.des = 0;
 
        int font_width = 0;

Reply via email to