[LyX/master] Remove useless test

[Jean-Marc]

commit d786d98c364f842ab5330307b11443afae1f5010
Author: Jean-Marc <lasgout...@lyx.org>
Date:   Sat Sep 12 19:53:29 2015 +0200

    Remove useless test
    
    Coverity issue 23300.

diff --git a/src/frontends/qt4/Menus.cpp b/src/frontends/qt4/Menus.cpp
index a53b6bb..d0b5d91 100644
--- a/src/frontends/qt4/Menus.cpp
+++ b/src/frontends/qt4/Menus.cpp
@@ -1122,12 +1122,10 @@ void MenuDefinition::expandFormats(MenuItem::Kind const 
kind, Buffer const * buf
                        label += '|' + shortcut;
 
                if (view_update) {
-                       if (buf)
-                               
item.submenu().addWithStatusCheck(MenuItem(MenuItem::Command,
-                                       toqstr(label), FuncRequest(action, 
(*fit)->name())));
-                       else
-                               item.submenu().add(MenuItem(MenuItem::Command, 
toqstr(label),
-                                       FuncRequest(action, (*fit)->name())));
+                       // note that at this point, we know that buf is not null
+                       LATTEST(buf);
+                       
item.submenu().addWithStatusCheck(MenuItem(MenuItem::Command,
+                               toqstr(label), FuncRequest(action, 
(*fit)->name())));
                } else {
                        if (buf)
                                addWithStatusCheck(MenuItem(MenuItem::Command, 
toqstr(label),