[LyX/master] Revert "Update previews on preference change (#9507)"

[Scott Kostyshak]

commit 358745d0e36c35d906c99e3d41f467bf499ce0ca
Author: Scott Kostyshak <skost...@lyx.org>
Date:   Wed Nov 11 18:06:07 2015 -0500

    Revert "Update previews on preference change (#9507)"
    
    The referenced commit lead to performance issues and possibly
    crashes in some cases when saving preferences. Thanks to Guillaume
    for discovering the issues. See #9828 for more discussion.
    
    I hope to come up with a better fix for #9507.
    
    This reverts commit 390ae05444cf4899a3028dcbbfe1095ecd2d207a.

diff --git a/src/BufferList.cpp b/src/BufferList.cpp
index 68a1e80..c253282 100644
--- a/src/BufferList.cpp
+++ b/src/BufferList.cpp
@@ -344,15 +344,6 @@ void BufferList::recordCurrentAuthor(Author const & author)
 }
 
 
-void BufferList::updatePreviews()
-{
-       BufferStorage::iterator it = bstore.begin();
-       BufferStorage::iterator end = bstore.end();
-       for (; it != end; ++it)
-               (*it)->updatePreviews();
-}
-
-
 int BufferList::bufferNum(FileName const & fname) const
 {
        FileNameList const buffers(fileNames());
diff --git a/src/BufferList.h b/src/BufferList.h
index 242eff0..4f9cb95 100644
--- a/src/BufferList.h
+++ b/src/BufferList.h
@@ -115,8 +115,6 @@ public:
        //@{
        /// reset current author for all buffers
        void recordCurrentAuthor(Author const & author);
-       /// update previews for all buffers, e.g. for Prefs update
-       void updatePreviews();
        /// Call changed() on all buffers, internal or not
        void changed(bool update_metrics) const;
        /// emergency save for all buffers
diff --git a/src/frontends/qt4/GuiPrefs.cpp b/src/frontends/qt4/GuiPrefs.cpp
index f7c00f4..a076402 100644
--- a/src/frontends/qt4/GuiPrefs.cpp
+++ b/src/frontends/qt4/GuiPrefs.cpp
@@ -3371,8 +3371,6 @@ void GuiPreferences::dispatchParams()
                update_screen_font_ = false;
        }
 
-       theBufferList().updatePreviews();
-
        // The Save button has been pressed
        if (isClosing())
                dispatch(FuncRequest(LFUN_PREFERENCES_SAVE));