[LyX/master] Make spellchecker dotted underlines thicker.

[Jean-Marc Lasgouttes]

commit 1546b91f27c6661cf5c22e22894ebfaa6f629ae9
Author: Jean-Marc Lasgouttes <lasgout...@lyx.org>
Date:   Wed Nov 25 22:09:45 2015 +0100

    Make spellchecker dotted underlines thicker.

diff --git a/src/RowPainter.cpp b/src/RowPainter.cpp
index ce5780b..ec083e9 100644
--- a/src/RowPainter.cpp
+++ b/src/RowPainter.cpp
@@ -62,7 +62,7 @@ RowPainter::RowPainter(PainterInfo & pi,
          pm_(text_metrics_.parMetrics(pit)), change_(pi_.change_),
          xo_(x), yo_(y), width_(text_metrics_.width()),
          solid_line_thickness_(1), solid_line_offset_(1),
-         dotted_line_thickness_(1), dotted_line_offset_(2)
+         dotted_line_thickness_(1)
 {
        if (lyxrc.zoom >= 200) {
                // derive the line thickness from zoom factor
@@ -77,8 +77,6 @@ RowPainter::RowPainter(PainterInfo & pi,
                // the zoom is given in percent
                // (increase thickness at 150%, 250% etc.)
                dotted_line_thickness_ = (lyxrc.zoom + 50) / 100;
-               // adjust line_offset_ too
-               dotted_line_offset_ = 1 + dotted_line_thickness_ / 2;
        }
 
        x_ = row_.left_margin + xo_;
@@ -183,9 +181,11 @@ void RowPainter::paintMisspelledMark(double const orig_x,
 {
        // if changed the misspelled marker gets placed slightly lower than 
normal
        // to avoid drawing at the same vertical offset
+       FontMetrics const & fm = theFontMetrics(e.font);
+       int const thickness = max(fm.lineWidth(), 2);
        int const y = yo_ + solid_line_offset_ + solid_line_thickness_
                + (e.change.changed() ? solid_line_thickness_ + 1 : 0)
-               + dotted_line_offset_;
+               + 1 + thickness / 2;
 
        //FIXME: this could be computed only once, it is probably not costly.
        // check for cursor position
@@ -228,7 +228,7 @@ void RowPainter::paintMisspelledMark(double const orig_x,
 
                pi_.pain.line(int(orig_x) + x1, y, int(orig_x) + x2, y,
                              Color_error,
-                             Painter::line_onoffdash, dotted_line_thickness_);
+                             Painter::line_onoffdash, thickness);
                pos = range.last + 1;
        }
 }
diff --git a/src/RowPainter.h b/src/RowPainter.h
index 6d5a8c6..a4120e6 100644
--- a/src/RowPainter.h
+++ b/src/RowPainter.h
@@ -103,7 +103,6 @@ private:
        int solid_line_thickness_;
        int solid_line_offset_;
        int dotted_line_thickness_;
-       int dotted_line_offset_;
 };
 
 } // namespace lyx