[LyX/2.2.x] Fix drawing of buttonText (enforce same left/right spacing)

[Richard Heck]

commit aa522e7071b1b7c8e168e703e6437dd3742c58b6
Author: Jean-Marc Lasgouttes <lasgout...@lyx.org>
Date:   Mon May 23 15:24:13 2016 +0200

    Fix drawing of buttonText (enforce same left/right spacing)
    
    The computation of the width of the button was wrong. If <--> stands
    for TEXT_TO_INSET_OFFSET/2 spacing, and if `[]' marks the button's
    limits, then the intent is
      <-->[<-->button text<-->]<-->
    
    Therefore the physical grey rectangle width is
       width - Inset::TEXT_TO_INSET_OFFSET
    
    With this change, the spacing on the right of the button is not larger
    than the left one.
    
    Fixes bug #10147.
    (cherry picked from commit 516d5d29dce28deab4601ec6aa714ca7ff59e6cd)

diff --git a/src/frontends/qt4/GuiPainter.cpp b/src/frontends/qt4/GuiPainter.cpp
index f1eb35e..1434ce7 100644
--- a/src/frontends/qt4/GuiPainter.cpp
+++ b/src/frontends/qt4/GuiPainter.cpp
@@ -590,7 +590,7 @@ void GuiPainter::buttonText(int x, int y, docstring const & 
str,
 
        static int const d = Inset::TEXT_TO_INSET_OFFSET / 2;
 
-       button(x + d, y - ascent, width - d, descent + ascent, mouseHover);
+       button(x + d, y - ascent, width - Inset::TEXT_TO_INSET_OFFSET, descent 
+ ascent, mouseHover);
        text(x + Inset::TEXT_TO_INSET_OFFSET, y, str, font);
 }
 
diff --git a/status.22x b/status.22x
index 2878588..842d2f9 100644
--- a/status.22x
+++ b/status.22x
@@ -121,6 +121,8 @@ What's new
 
 - Remove extra spacing around  button insets (bug 10149).
 
+- Fix drawing of buttons by enforcing equal left/right spacing (bug 10147).
+
 * INTERNALS