commit 25d64bf43aba78a1ed20c88dfdc4cac269b53985
Author: Jean-Marc Lasgouttes <[email protected]>
Date:   Tue Mar 7 11:56:59 2017 +0100

    Fix test to make coverity happy
    
    It is not obvious that cur is not null iff thisSlice is not -1, but
    this is what happens in the caller.
---
 src/mathed/MathData.cpp |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/src/mathed/MathData.cpp b/src/mathed/MathData.cpp
index 3f298af..9d21898 100644
--- a/src/mathed/MathData.cpp
+++ b/src/mathed/MathData.cpp
@@ -781,7 +781,10 @@ void MathData::collectParameters(Cursor * cur,
                // fix cursor
                vector<CursorSlice> argSlices;
                int argPos = 0;
-               if (thisSlice != -1 && thisPos == int(pos))
+               // Note: The two expressions on the first line are equivalent
+               // (see caller), but making this explicit pleases coverity.
+               if (cur && thisSlice != -1
+                       && thisPos == int(pos))
                        cur->cutOff(thisSlice, argSlices);
 
                // which kind of parameter is it? In {}? With index x^n?

Reply via email to