commit 4a7bc8d277575394c760a2aa210129c77c628f0c
Author: Jean-Marc Lasgouttes <[email protected]>
Date: Sat Jun 21 20:27:23 2025 +0200
Pass arguments as const reference
Spotted by cppcheck
---
src/BiblioInfo.cpp | 14 +++++++-------
src/BiblioInfo.h | 4 ++--
src/Buffer.cpp | 3 +--
src/Buffer.h | 2 +-
src/BufferParams.cpp | 6 +++---
src/BufferParams.h | 6 +++---
src/Counters.cpp | 2 +-
src/TexRow.cpp | 12 ++++++------
src/TexRow.h | 12 ++++++------
src/frontends/qt/FindAndReplace.cpp | 2 +-
src/frontends/qt/FindAndReplace.h | 2 +-
src/frontends/qt/GuiToolbar.cpp | 2 +-
src/frontends/qt/GuiToolbar.h | 2 +-
src/frontends/qt/qt_helpers.cpp | 2 +-
src/frontends/qt/qt_helpers.h | 7 +++----
src/insets/InsetIndex.cpp | 2 +-
src/insets/InsetIndex.h | 2 +-
src/insets/InsetLayout.cpp | 2 +-
src/insets/InsetLayout.h | 2 +-
src/insets/InsetRef.cpp | 2 +-
src/insets/InsetRef.h | 2 +-
src/lyxfind.cpp | 22 +++++++++++-----------
src/mathed/InsetMathXArrow.cpp | 2 +-
src/mathed/MathStream.cpp | 2 +-
src/mathed/MathStream.h | 2 +-
src/support/weighted_btree.h | 4 ++--
26 files changed, 60 insertions(+), 62 deletions(-)
diff --git a/src/BiblioInfo.cpp b/src/BiblioInfo.cpp
index 15e5772068..85f782cf2c 100644
--- a/src/BiblioInfo.cpp
+++ b/src/BiblioInfo.cpp
@@ -1574,10 +1574,10 @@ void BiblioInfo::makeCitationLabels(Buffer const & buf)
// time through the loop. If so, then we do not have
anything
// with which to compare.
if (last != bimap_.end()
- && entry.getAuthorOrEditorList() ==
last->second.getAuthorOrEditorList()
- // we access the year via getYear() so as to get it
from the xref,
- // if we need to do so
- && getYear(entry.key()) ==
getYear(last->second.key())) {
+ && entry.getAuthorOrEditorList() ==
last->second.getAuthorOrEditorList()
+ // we access the year via getYear() so as to get
it from the xref,
+ // if we need to do so
+ && getYear(entry.key()) ==
getYear(last->second.key())) {
if (modifier == 0) {
// so the last one should have been 'a'
last->second.setModifier('a');
@@ -1626,7 +1626,7 @@ void BiblioInfo::makeCitationLabels(Buffer const & buf)
CitationStyle citationStyleFromString(string const & command,
- BufferParams const & params)
+ BufferParams const & params)
{
CitationStyle cs;
if (command.empty())
@@ -1662,8 +1662,8 @@ string citationStyleToString(const CitationStyle & cs,
bool const latex)
}
-void authorsToDocBookAuthorGroup(docstring const & authorsString, XMLStream &
xs, Buffer const & buf,
- const std::string type)
+void authorsToDocBookAuthorGroup(docstring const & authorsString, XMLStream &
xs,
+ Buffer const & buf, const std::string & type)
{
// This function closely mimics getAuthorList, but produces DocBook
instead of text.
// It has been greatly simplified, as the complete list of authors is
always produced. No separators are required,
diff --git a/src/BiblioInfo.h b/src/BiblioInfo.h
index c42d3e0318..e5088d0b4c 100644
--- a/src/BiblioInfo.h
+++ b/src/BiblioInfo.h
@@ -39,8 +39,8 @@ std::string citationStyleToString(CitationStyle const &, bool
const latex = fals
/// Transforms the information about authors into a <authorgroup> (directly
written to a XMLStream).
/// Type: "author" or empty means author of the entry (article, book, etc.);
"book" means author of the book
/// (but not necessarily of this entry in particular).
-void authorsToDocBookAuthorGroup(docstring const & authorsString, XMLStream &
xs, Buffer const & buf,
- std::string
type);
+void authorsToDocBookAuthorGroup(docstring const & authorsString, XMLStream &
xs,
+ Buffer const & buf, std::string const & type);
/// Class to represent information about a BibTeX or
diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index f1e226aad9..97c99f3de7 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -1231,8 +1231,7 @@ bool Buffer::readString(string const & s)
}
-Buffer::ReadStatus Buffer::readFile(FileName const & fn,
- string const ofn)
+Buffer::ReadStatus Buffer::readFile(FileName const & fn, string const & ofn)
{
Lexer lex;
if (!lex.setFile(fn)) {
diff --git a/src/Buffer.h b/src/Buffer.h
index d51776d3ff..0e0e02c871 100644
--- a/src/Buffer.h
+++ b/src/Buffer.h
@@ -244,7 +244,7 @@ private:
void saveCheckSum() const;
/// read a new file
ReadStatus readFile(support::FileName const & fn,
- std::string ofn = std::string());
+ std::string const & ofn = std::string());
/// Reads a file without header.
/// \param par if != 0 insert the file.
/// \return \c true if file is not completely read.
diff --git a/src/BufferParams.cpp b/src/BufferParams.cpp
index 342193c061..66499dec19 100644
--- a/src/BufferParams.cpp
+++ b/src/BufferParams.cpp
@@ -3423,7 +3423,7 @@ bool BufferParams::isLiterate() const
}
-bool BufferParams::hasPackageOption(string const package, string const opt)
const
+bool BufferParams::hasPackageOption(string const & package, string const &
opt) const
{
for (auto const & p : documentClass().packageOptions())
if (package == p.first && opt == p.second)
@@ -3432,7 +3432,7 @@ bool BufferParams::hasPackageOption(string const package,
string const opt) cons
}
-string BufferParams::getPackageOptions(string const package) const
+string BufferParams::getPackageOptions(string const & package) const
{
for (auto const & p : documentClass().packageOptions())
if (package == p.first)
@@ -4341,7 +4341,7 @@ bool BufferParams::isActiveCiteStyle(CitationStyle const
& cs) const
return false;
}
-string const BufferParams::getBibtexCommand(string const cmd, bool const warn)
const
+string const BufferParams::getBibtexCommand(string const & cmd, bool const
warn) const
{
// split from options
string command_in;
diff --git a/src/BufferParams.h b/src/BufferParams.h
index ee98e49957..7723c6f416 100644
--- a/src/BufferParams.h
+++ b/src/BufferParams.h
@@ -201,9 +201,9 @@ public:
/// returns \c true if the buffer contains a Wed document
bool isLiterate() const;
/// Is this package option requested?
- bool hasPackageOption(std::string const package, std::string const opt)
const;
+ bool hasPackageOption(std::string const & package, std::string const &
opt) const;
/// Get the options requested for a given package
- std::string getPackageOptions(std::string const package) const;
+ std::string getPackageOptions(std::string const & package) const;
/// Do we use the bidi package (which does some reordering and stuff)?
bool useBidiPackage(OutputParams const & rp) const;
@@ -702,7 +702,7 @@ private:
/// Split bibliography?
bool use_bibtopic;
/// Return the actual or an appropriate fallback bibtex command
- std::string const getBibtexCommand(std::string const cmd,
+ std::string const getBibtexCommand(std::string const & cmd,
bool const warn) const;
///
DocumentClassPtr doc_class_;
diff --git a/src/Counters.cpp b/src/Counters.cpp
index 371691072e..dda0807faa 100644
--- a/src/Counters.cpp
+++ b/src/Counters.cpp
@@ -623,7 +623,7 @@ docstring Counters::counterLabel(docstring const & format,
namespace {
-docstring getFormattedLabel(docstring in, bool const lc, bool const pl)
+docstring getFormattedLabel(docstring const & in, bool const lc, bool const pl)
{
if (contains(in, from_ascii("|"))) {
docstring res;
diff --git a/src/TexRow.cpp b/src/TexRow.cpp
index 9c20f25df9..9a40c60795 100644
--- a/src/TexRow.cpp
+++ b/src/TexRow.cpp
@@ -116,14 +116,14 @@ TexRow::RowEntry const TexRow::row_none =
TexRow::textEntry(-1, 0);
//static
-bool TexRow::isNone(TextEntry t)
+bool TexRow::isNone(TextEntry const & t)
{
return t.id < 0;
}
//static
-bool TexRow::isNone(RowEntry r)
+bool TexRow::isNone(RowEntry const & r)
{
return r.type == text_entry && isNone(r.text);
}
@@ -174,7 +174,7 @@ TexRow::RowEntry TexRow::beginDocument()
}
-bool operator==(TexRow::RowEntry entry1, TexRow::RowEntry entry2)
+bool operator==(TexRow::RowEntry const & entry1, TexRow::RowEntry const &
entry2)
{
if (entry1.type != entry2.type)
return false;
@@ -193,7 +193,7 @@ bool operator==(TexRow::RowEntry entry1, TexRow::RowEntry
entry2)
}
-bool TexRow::start(RowEntry entry)
+bool TexRow::start(RowEntry const & entry)
{
return currentRow().addEntry(entry);
}
@@ -406,7 +406,7 @@ bool TexRow::sameParOrInsetMath(RowEntry entry1, RowEntry
entry2)
//static
-int TexRow::comparePos(RowEntry entry1, RowEntry entry2)
+int TexRow::comparePos(RowEntry const & entry1, RowEntry const & entry2)
{
// assume it is sameParOrInsetMath
switch (entry1.type /* equal to entry2.type */) {
@@ -637,7 +637,7 @@ void TexRow::setRows(size_t r)
// debugging functions
///
-docstring TexRow::asString(RowEntry entry)
+docstring TexRow::asString(RowEntry const & entry)
{
odocstringstream os;
switch (entry.type) {
diff --git a/src/TexRow.h b/src/TexRow.h
index e40867d7b1..9bf93272ec 100644
--- a/src/TexRow.h
+++ b/src/TexRow.h
@@ -87,9 +87,9 @@ public:
static const TextEntry text_none;
static const RowEntry row_none;
/// Returns true if RowEntry is devoid of information
- static bool isNone(RowEntry entry);
+ static bool isNone(RowEntry const & entry);
/// Returns true if TextEntry is devoid of information
- static bool isNone(TextEntry entry);
+ static bool isNone(TextEntry const & entry);
private:
/// id/pos correspondence for a single row
@@ -126,11 +126,11 @@ public:
void reset();
/// for debugging purposes
- static docstring asString(RowEntry entry);
+ static docstring asString(RowEntry const & entry);
/// Defines the row information for the current line
/// returns true if this entry will appear on the current row
- bool start(RowEntry entry);
+ bool start(RowEntry const & entry);
/// Defines the paragraph and position for the current line
/// returns true if this entry will appear on the current row
bool start(int id, pos_type pos);
@@ -215,7 +215,7 @@ private:
static bool sameParOrInsetMath(RowEntry entry1, RowEntry entry2);
/// computes the distance in pos or cell index
/// assumes it is the sameParOrInsetMath
- static int comparePos(RowEntry entry1, RowEntry entry2);
+ static int comparePos(RowEntry const & entry1, RowEntry const & entry2);
};
@@ -289,7 +289,7 @@ public:
};
-bool operator==(TexRow::RowEntry entry1, TexRow::RowEntry entry2);
+bool operator==(TexRow::RowEntry const & entry1, TexRow::RowEntry const &
entry2);
} // namespace lyx
diff --git a/src/frontends/qt/FindAndReplace.cpp
b/src/frontends/qt/FindAndReplace.cpp
index db47173624..a1d8ef406d 100644
--- a/src/frontends/qt/FindAndReplace.cpp
+++ b/src/frontends/qt/FindAndReplace.cpp
@@ -511,7 +511,7 @@ bool FindAndReplaceWidget::findAndReplace(
}
-docstring const FindAndReplaceWidget::checkState(string const s, bool const b)
+docstring const FindAndReplaceWidget::checkState(string const & s, bool const
b)
{
docstring res = from_ascii(s) + from_ascii(" ");
if (b)
diff --git a/src/frontends/qt/FindAndReplace.h
b/src/frontends/qt/FindAndReplace.h
index cb4691a07b..b71f72db9a 100644
--- a/src/frontends/qt/FindAndReplace.h
+++ b/src/frontends/qt/FindAndReplace.h
@@ -71,7 +71,7 @@ private:
void setFormatIgnores(bool const b);
- docstring const checkState(std::string const s, bool const b);
+ docstring const checkState(std::string const & s, bool const b);
protected Q_SLOTS:
void on_findNextPB_clicked();
diff --git a/src/frontends/qt/GuiToolbar.cpp b/src/frontends/qt/GuiToolbar.cpp
index 0bd8c6097c..fddd49f48e 100644
--- a/src/frontends/qt/GuiToolbar.cpp
+++ b/src/frontends/qt/GuiToolbar.cpp
@@ -661,7 +661,7 @@ bool GuiToolbar::isVisibilityOn() const
}
-void GuiToolbar::setState(string const state)
+void GuiToolbar::setState(string const & state)
{
docstring newstate;
if (state == "auto") {
diff --git a/src/frontends/qt/GuiToolbar.h b/src/frontends/qt/GuiToolbar.h
index 1b780b6bbb..6ec61acb48 100644
--- a/src/frontends/qt/GuiToolbar.h
+++ b/src/frontends/qt/GuiToolbar.h
@@ -154,7 +154,7 @@ public:
void update(int context = 0);
///
- void setState(std::string const state);
+ void setState(std::string const & state);
///
void toggle();
diff --git a/src/frontends/qt/qt_helpers.cpp b/src/frontends/qt/qt_helpers.cpp
index ce5c3d2636..74fa0af03a 100644
--- a/src/frontends/qt/qt_helpers.cpp
+++ b/src/frontends/qt/qt_helpers.cpp
@@ -268,7 +268,7 @@ void focusAndHighlight(QAbstractItemView * w)
}
-void setMessageColour(list<QWidget *> highlighted, list<QWidget *> plain)
+void setMessageColour(list<QWidget *> const & highlighted, list<QWidget *>
const & plain)
{
QPalette pal = QApplication::palette();
QPalette newpal(pal.color(QPalette::Active, QPalette::HighlightedText),
diff --git a/src/frontends/qt/qt_helpers.h b/src/frontends/qt/qt_helpers.h
index ea606f8a96..887e435653 100644
--- a/src/frontends/qt/qt_helpers.h
+++ b/src/frontends/qt/qt_helpers.h
@@ -87,16 +87,15 @@ void focusAndHighlight(QAbstractItemView * w);
// Sets all widget in highlighted in highlighted colour, and their children in
// plain in standard colours.
-void setMessageColour(std::list<QWidget *> highlighted,
- std::list<QWidget *> plain);
+void setMessageColour(std::list<QWidget *> const & highlighted,
+ std::list<QWidget *> const & plain);
/// Shows a directory in OSs file browser
void showDirectory(support::FileName const & directory);
/// handle request for showing citation content - shows pdf/ps or
/// web page in target; external script can be used for pdf/ps view
/// \p docpath holds the document path
-void showTarget(std::string const & target,
- Buffer const & buf);
+void showTarget(std::string const & target, Buffer const & buf);
} // namespace frontend
diff --git a/src/insets/InsetIndex.cpp b/src/insets/InsetIndex.cpp
index 4466c1a75d..e1d61bb43f 100644
--- a/src/insets/InsetIndex.cpp
+++ b/src/insets/InsetIndex.cpp
@@ -972,7 +972,7 @@ bool InsetIndex::hasSortKey() const
}
-bool InsetIndex::macrosPossible(string const type) const
+bool InsetIndex::macrosPossible(string const & type) const
{
if (type != "see" && type != "seealso"
&& type != "sortkey" && type != "subentry")
diff --git a/src/insets/InsetIndex.h b/src/insets/InsetIndex.h
index f09596df17..c415c1acd6 100644
--- a/src/insets/InsetIndex.h
+++ b/src/insets/InsetIndex.h
@@ -128,7 +128,7 @@ private:
///
bool hasSortKey() const;
///
- bool macrosPossible(std::string const type) const;
+ bool macrosPossible(std::string const & type) const;
///
std::string contextMenuName() const override;
///
diff --git a/src/insets/InsetLayout.cpp b/src/insets/InsetLayout.cpp
index 988fef6781..8249da89c3 100644
--- a/src/insets/InsetLayout.cpp
+++ b/src/insets/InsetLayout.cpp
@@ -1023,7 +1023,7 @@ int InsetLayout::requiredArgs() const
}
-bool InsetLayout::requiresFeature(string const f) const
+bool InsetLayout::requiresFeature(string const & f) const
{
return required_.find(f) != required_.end();
}
diff --git a/src/insets/InsetLayout.h b/src/insets/InsetLayout.h
index eb1bb1df86..9038e56baf 100644
--- a/src/insets/InsetLayout.h
+++ b/src/insets/InsetLayout.h
@@ -204,7 +204,7 @@ public:
///
std::set<std::string> const & required() const { return required_; }
///
- bool requiresFeature(std::string const f) const;
+ bool requiresFeature(std::string const & f) const;
///
bool isMultiPar() const { return multipar_; }
///
diff --git a/src/insets/InsetRef.cpp b/src/insets/InsetRef.cpp
index deea20a413..5058ff62df 100644
--- a/src/insets/InsetRef.cpp
+++ b/src/insets/InsetRef.cpp
@@ -231,7 +231,7 @@ bool InsetRef::getStatus(Cursor & cur, FuncRequest const &
cmd,
// label, thus: \prettyref{pfx:suffix}.
//
docstring InsetRef::getFormattedCmd(docstring const & ref,
- vector<docstring> & label, docstring & prefix, string const
xref_package,
+ vector<docstring> & label, docstring & prefix, string const &
xref_package,
bool use_caps, bool use_range)
{
docstring defcmd = from_ascii("\\ref");
diff --git a/src/insets/InsetRef.h b/src/insets/InsetRef.h
index b97608d313..5050ac708d 100644
--- a/src/insets/InsetRef.h
+++ b/src/insets/InsetRef.h
@@ -101,7 +101,7 @@ public:
/// \param prefix of the label (before :)
/// Also used by InsetMathRef
static docstring getFormattedCmd(docstring const & ref,
std::vector<docstring> & label,
- docstring & prefix, std::string const xref_package,
+ docstring & prefix, std::string const & xref_package,
bool use_caps = false, bool use_range = false);
protected:
diff --git a/src/lyxfind.cpp b/src/lyxfind.cpp
index ff7d073cf8..ab337cb54d 100644
--- a/src/lyxfind.cpp
+++ b/src/lyxfind.cpp
@@ -234,7 +234,7 @@ private:
};
-int findForward(DocIterator & cur, DocIterator const endcur,
+int findForward(DocIterator & cur, DocIterator const & endcur,
MatchString const & match,
bool find_del = true, bool onlysel = false)
{
@@ -252,7 +252,7 @@ int findForward(DocIterator & cur, DocIterator const endcur,
}
-int findBackwards(DocIterator & cur, DocIterator const endcur,
+int findBackwards(DocIterator & cur, DocIterator const & endcur,
MatchString const & match,
bool find_del = true, bool onlysel = false)
{
@@ -624,7 +624,7 @@ bool lyxfind(BufferView * bv, FuncRequest const & ev)
bool wrap;
bool instant;
bool onlysel;
-
+
docstring search = string2find(ev.argument(), casesensitive,
matchword, forward, wrap, instant,
onlysel);
@@ -1026,7 +1026,7 @@ string correctRegex(string t, bool withformat)
/// Within \regexp{} apply get_lyx_unescapes() only (i.e., preserve regexp
semantics of the string),
/// while outside apply get_lyx_unescapes()+get_regexp_escapes().
/// If match_latex is true, then apply regexp_latex_escapes() to \regexp{}
contents as well.
-string escape_for_regex(string s, bool withformat)
+string escape_for_regex(string const & s, bool withformat)
{
size_t lastpos = 0;
string result = "";
@@ -1225,7 +1225,7 @@ static docstring buffer_to_latex(Buffer & buffer)
return ods.str();
}
-static string latexNamesToUtf8(docstring strIn, bool withformat)
+static string latexNamesToUtf8(docstring const & strIn, bool withformat)
{
string addtmp = to_utf8(strIn);
static regex const rmAcc("(\\\\)*("
@@ -1654,7 +1654,7 @@ void Intervall::addIntervall(int low, int upper)
}
}
-static void buildaccent(string n, string param, string values)
+static void buildaccent(string n, string param, string const & values)
{
stringstream s(n);
string name;
@@ -1725,7 +1725,7 @@ static string getutf8(unsigned uchar)
return(ret);
}
-static void addAccents(string latex_in, string unicode_out)
+static void addAccents(string latex_in, string const & unicode_out)
{
latex_in = latex_in.substr(1);
AccentsIterator it_ac = accents.find(latex_in);
@@ -2412,7 +2412,7 @@ private:
Intervall interval_;
void buildKeys(bool);
void buildEntries(bool);
- void makeKey(const string &, KeyInfo, bool isPatternString);
+ void makeKey(const string &, KeyInfo const & , bool isPatternString);
void processRegion(int start, int region_end); /* remove {} parts */
void removeHead(KeyInfo const &, int count=0);
@@ -3004,7 +3004,7 @@ void LatexInfo::buildEntries(bool isPatternString)
}
}
-void LatexInfo::makeKey(const string &keysstring, KeyInfo keyI, bool
isPatternString)
+void LatexInfo::makeKey(const string & keysstring, KeyInfo const & keyI, bool
isPatternString)
{
stringstream s(keysstring);
string key;
@@ -3631,7 +3631,7 @@ int LatexInfo::process(ostringstream & os, KeyInfo const
& actual )
return nextKeyIdx;
}
-string splitOnKnownMacros(string par, bool isPatternString)
+string splitOnKnownMacros(string const & par, bool isPatternString)
{
ostringstream os;
LatexInfo li(par, isPatternString);
@@ -4443,7 +4443,7 @@ docstring latexifyFromCursor(DocIterator const & cur, int
len)
#if defined(ResultsDebug)
// Debugging output
-static void displayMResult(MatchResult &mres, string from, DocIterator & cur)
+static void displayMResult(MatchResult &mres, string const & from, DocIterator
& cur)
{
LYXERR0( "from:\t\t\t" << from);
string status;
diff --git a/src/mathed/InsetMathXArrow.cpp b/src/mathed/InsetMathXArrow.cpp
index c20bdb39c5..b6afb7eb95 100644
--- a/src/mathed/InsetMathXArrow.cpp
+++ b/src/mathed/InsetMathXArrow.cpp
@@ -104,7 +104,7 @@ static std::map<string, string> latex_to_xml_entities = {
};
-docstring map_latex_to(docstring latex)
+static docstring map_latex_to(docstring const & latex)
{
auto mapping = latex_to_xml_entities.find(to_ascii(latex));
if (mapping != latex_to_xml_entities.end()) {
diff --git a/src/mathed/MathStream.cpp b/src/mathed/MathStream.cpp
index 97fb0d5ffa..8ee1c4c33f 100644
--- a/src/mathed/MathStream.cpp
+++ b/src/mathed/MathStream.cpp
@@ -498,7 +498,7 @@ void TeXMathStream::asciiOnly(bool ascii)
}
-Changer TeXMathStream::changeRowEntry(TexRow::RowEntry entry)
+Changer TeXMathStream::changeRowEntry(TexRow::RowEntry const & entry)
{
return changeVar(row_entry_, entry);
}
diff --git a/src/mathed/MathStream.h b/src/mathed/MathStream.h
index daddfe9f28..c4ff39a5f9 100644
--- a/src/mathed/MathStream.h
+++ b/src/mathed/MathStream.h
@@ -211,7 +211,7 @@ public:
Encoding const * encoding() const { return encoding_; }
/// Temporarily change the TexRow information about the outer row entry.
- Changer changeRowEntry(TexRow::RowEntry entry);
+ Changer changeRowEntry(TexRow::RowEntry const & entry);
/// TexRow::starts the innermost outer math inset
/// returns true if the outer row entry will appear at this line
bool startOuterRow();
diff --git a/src/support/weighted_btree.h b/src/support/weighted_btree.h
index 86063c3ae9..ca6122d9b1 100644
--- a/src/support/weighted_btree.h
+++ b/src/support/weighted_btree.h
@@ -925,7 +925,7 @@ private:
// *** Convenient Key Comparison Functions Generated From key_less
/// True if a <= b ? constructed from key_less()
- inline bool key_lessequal(const key_type &a, const key_type b) const
+ inline bool key_lessequal(const key_type &a, const key_type &b) const
{
return !key_less(b, a);
}
@@ -937,7 +937,7 @@ private:
}
/// True if a >= b ? constructed from key_less()
- inline bool key_greaterequal(const key_type &a, const key_type b) const
+ inline bool key_greaterequal(const key_type &a, const key_type &b) const
{
return !key_less(a, b);
}
--
lyx-cvs mailing list
[email protected]
https://lists.lyx.org/mailman/listinfo/lyx-cvs