>>>>> "Edmar" == Edmar Wienskoski <[EMAIL PROTECTED]> writes:
Edmar> Here are the literate programming patches again. I did all the
Edmar> requested modifications and put them in one single patch
Edmar> (against pre6). I will go quickly over each one and tell what I
Edmar> have modified from my original post.
Thanks for the submission. I commited parts of those patches.
First, I really like the quality of the patches and the way they
integrate to LyX. I guess this was to be expected from somebody who
uses web techniques ;)
In fact, I did not took the parts which directly relate to litterate
programming for two reasons:
- it is a big change, that have to be properly documented and tested
(although I trust your own tests on this one). I would not want to
delay 1.0.0 for this and it could easily go into 1.0.1.
- I am waiting a bit for Lars' decision on this one, since he is the
main architext.
Now for the details:
>> 1 - The first patch is to allow the choice of the color of the
>> new-line character. ... Obs: The default color is the same it is
>> today.
Edmar> This patch remains the same.
I took this one.
>> 2 - Patch to include new shortcut buttons in the toolbar. ... Obs:
>> The customization of the toolbar itself is left to the user do in
>> his/her lyxrc file. Thus, the toolbar defaults to its present
>> looks.
Edmar> This patch remains the same.
This one is fine, but does not make sense until the rest is in.
>> 3 - Patch to not output the protected space '~' during translation
>> of latex paragraphs. ...
Edmar> This patch remains the same.
This one was already in.
>> 4 - Patch to always produce "nice-latex"....
This one is good, but I did not take it because it depends on the rest.
>> 5 - Patch to allow Item_Environment and Environment layouts to have
>> a "dummy" latex command name....
Edmar> Eliminated.
Fine.
>> 6 - The addition of the Scrap layout to lyxmacros.inc....
Edmar> Not anymore...
That's fine. Note that you should define OutputType after Inputing
article.layout, since someone could decide to add 'OutputType latex'
in there ;)
Other than that, it looks fine to me.
>> 7 - Patch to have different buttons and menu options for running
>> latex, and building the code. The following new entries in the
>> lyxrc are possible now:
>>
>> command: default: \web_command noweave -delay -index \web_extension
>> .nw \web_error_filter cat \build_command make \build_error_filter
>> cat
Some comments:
- could you write a short documentation about those in lyxrc?
[something for the real docs about litterate programming would be nice
too, but that's more work]
- the default values for these commands should be "none" and the
existence of the relevant programs should be tested in lib/configure
(have a look at config/lib_configure.m4 to see how it works). If you
have a problem with this, tell me what has to be tested for and I'll
add it. The textclasses should be made available only if the program
is found.
- I am a bit worried that the 'web' name can be confusing for many
users. Would it be possible to find another generic buzzword to
describe that?
Edmar> In summary, the only difference a plain text user will notice
Edmar> in LyX is the new entry in the file menu: "Build Program". If
Edmar> a user tries to execute it in a plain text document, a message
Edmar> will pop up. (Other way would be to gray it out ...)
It would be indeed better to grey it out when the buffer type is not
Web or \web_command is "none".
>> 8 - Patch to implement "server-goto-file-row" function....
>>
Edmar> This patch remains the same.
This one is in.
For reference, I append to this message a copy of what remains from
your patch. Since I edited that by hand, it is possible that I made
mistakes... I took only 20% of it yet, but all will eventually go in,
I guess.
Oh, and I added you to the CREDITS file.
JMarc
wiensk-981227-pending.patch.gz
