On Fri, Jul 23, 1999 at 07:02:16PM +0200, Jean-Marc Lasgouttes wrote:
> >>>>> "Jose" == Jose Abilio Oliveira Matos <[EMAIL PROTECTED]> writes:
>
> Jose> If you find any suspicious C++ constrution, please tell me,
> Jose> I'm still learning. And I really want to improve LyX code
> Jose> quality (my code of course :-)
>
> Let's see... The following enum would better be moved into the Buffer
> class (in buffer.h):
>
> + enum {NO_ONE,FOOTNOTE_LIKE,MARGIN_LIKE,FIG_LIKE,TAB_LIKE}
>last=NO_ONE,present=FOOTNOTE_LIKE;
I only need this enum in the function it is declared.
I wanted that the variables last and present had the same type, so
the comparison would only be possible between the same type.
The point is that this is local, why should it become visible
inside buffer.h
> Instead of using something like
> + extra_par="";
> you should do
> + extra_par.clean();
>
> Basically, "" should never appear in the code.
Thanks I have read the LString declaration and this bit escaped me.
> That's all I can think of.
>
> JMarc
Jos�
