On Sat, Sep 16, 2006 at 10:32:04AM +0100, Angus Leeming wrote:
> Enrico Forestieri wrote:
> > On Fri, Sep 15, 2006 at 09:27:52PM +0200, Joost Verburg wrote:
> >
> >> Angus Leeming wrote:
> >>> Doesn't this suggest that any "fix" ("kludge"?) should be wrapped inside
> >>> a #ifdef CYGWIN/MINGW block? How does this beast behave when compiled
> >>> with MSVC? Presumably that's what Joost would like to do for his Windows
> >>> installer, no?
> >> Indeed. The 1.4.3 Windows release, including tools like dt2dv/dv2dt,
> >> will be compiled with MSVC.
> >
> > However, I doubt that MSVC doesn't need at least the patch about
> > char -> unsigned char.
>
> Good point ;-) But the isprint stuff should be #ifdef-ed, no?
Maybe something like
#if defined(__CYGWIN__) || defined(__MINGW32__)
else if ( ! isprint (c & 0x7f) && ! isspace (c))
#else
else if ( ! isprint (c) && ! isspace (c))
#endif
But I still have to see whether the "#if" line is not to be augmented
by a " || defined(MSVC)" ;-)
--
Enrico
