Jean-Marc Lasgouttes wrote:
"Bo" == Bo Peng <[EMAIL PROTECTED]> writes:
Bo> Will something like attached be accepted? Basically, I move
Bo> LFUN_BOOKMARK_GOTO to lyxfunc.C and swith buffer via LyxView
Bo> instead of BufferView. A relocation of the whole bookmark feature
Bo> may worth further consideration though.
Are bookmarks global or per-document currently? If they are global,
the code should go to lyxfunc.C,
Yes.
if they are buffer-local, the code
should go to BufferView.C. It is as simple as that.
No in any case because one buffer may be used by more than BufferView.
Of course, the above may only show that I did not follow this thread
well enough. In this case, could some nice soul explain to me? I am
really against calling anything else than LyXFunc::dispatch, except if
there are _very_ good reasons.
The problem currently is that the bookmark stuff is in BufferView and it
_really_ should not be there. We should move them (I mean the entire
functionality) out of BufferView, either entirely in LyXFunc or partly
in LyXFunc and Buffer (the bookmark themselves.)
Abdel.
