On Tue, Dec 12, 2006 at 11:38:23AM +0100, Peter Kümmel wrote:

> Bo Peng wrote:
> >> We are not in a competition and I think that we should not waste
> >> resources, so I am going to commit the patch. Anyway, thank you
> >> for having polished the thing :)
> > 
> > Agreeed, please also update Status.15x regarding this.
> > 
> > Bo
> > 
> 
> OK, the only think which isn't perfect is the multiple
> call of quitWriteAll(), but it's maybe the simplest solution.

Indeed.

> You could declare quitting_by_menu_ in the Pimpl, then it
> isn't part of the public interface.

Please Peter, feel free to improve it as you deem necessary.
I reckon still there is much that can be done.

> Thanks Enrico for finishing my polishing.

And I thank you for your work.

> Seems everyone who touches the quit code spend at least
> one day on it.

It's really a can of worms...

-- 
Enrico

Reply via email to