Currently if the user chooses to "Show changes in output",
but does not use pplatex as an output filter, LyX happily
throws all the new text and old text into a big confusing
jumble.
I suggest that if the user trys to use latex or pdflatex
with show changes on, a warning dialog should be shown.
If a command other than pplatex, latex or pdflatex is used,
I also suggest not warning the user as the user may have a
reason for using the custom command, and may not appreciate
a warning dialog every single time they generate a dvi
with show changes enabled. (Perhaps all warning dialogs
should have a "Do not show this warning again" checkbox)
Here is a patch to warn the user that their changes are not
highlighted, and tell them why. I am not sure how many
coding guidelines this code breaks, but I would like
comments on the 1.4.4svn and 1.5.0svn patches below:
--- 1.4.4svn ---
Index: converter.C
===================================================================
--- converter.C (revision 16790)
+++ converter.C (working copy)
@@ -579,6 +579,10 @@
buffer.busy(true);
buffer.message(_("Running LaTeX..."));
+ if ( (command.compare("latex ")==0 || command.compare("pdflatex ")==0)
&& buffer.params().output_changes ) {
+ Alert::warning(_("Changes not highlighted"), command+_("does
not support dvipost\nuse pplatex instead"));
+ }
+
runparams.document_language = buffer.params().language->babel();
// do the LaTeX run(s)
--- 1.5.0svn ---
Index: converter.C
===================================================================
--- converter.C (revision 16830)
+++ converter.C (working copy)
@@ -596,6 +596,10 @@
buffer.busy(true);
buffer.message(_("Running LaTeX..."));
+ if ((command.compare("latex ")==0 || command.compare("pdflatex ")==0)
&& buffer.params().outputChanges) {
+ Alert::warning(_("Changes not highlighted"), _(command+"does
not support dvipost\nuse pplatex instead"));
+ }
+
runparams.document_language = buffer.params().language->babel();
// do the LaTeX run(s)
--
John C. McCabe-Dansted
PhD Student
University of Western Australia
