Georg Baum wrote:
Am Samstag, 27. Januar 2007 13:10 schrieb Abdelrazak Younes:
Georg, if you're going to do the lyx2lyx support, please take the patch
and commit it at the same time.
Here is the complete patch, but I discovered some problems that need to be
solved before it can go in:
- You deleted some (but not all) code that handles LABEL_SENSITIVE. I
reverted that, since we have other caption-like styles in layout files
that still need to work.
OK.
- The patch breaks optional arguments of captions. The most simple way to
fix that would be to check for InsetOptArg at the first paragraph position
in InsetCaption::latex(), and get the optional argument with
latexOptional() if there is one. This would not need any lyx2lyx change.
Of course it would also be possible to transfer the optional argument to
the caption inset, but I don't know a good UI.
This is outside of my competence.
- AFAIK not all layouts have a caption style, but with this patch we allow
captions in any documents. Is this a problem?
- In order to really fix bug 675 (Which started this thing) we need to
implement InsetCaption::getStatus() and disable several lfuns.
Once the optional argument question is answered we can put this in and do
the rest later.
Very good. I let you handle that then.
Thanks,
Abdel.
