>>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:

Georg> Georg Baum wrote:
>> Are you sure? IIRC that was done on purpose. Had something to do
>> with lyxserver/client, but I forgot the exact reason. 1.4 has the
>> code
>> 
>> sendDispatchMessage(_(getMessage()), cmd);
>> 
>> in LyXFunc::dispatch(), in 1.5 this reads
>> 
>> sendDispatchMessage(getMessage(), cmd);
>> 
>> which explains the missing translation. Why was this changed?

Georg> See here: http://www.lyx.org/trac/changeset/15019

Georg> Looks like a half-baked solution. I'd say we should find out
Georg> why we did translate getMessage() and not the individual
Georg> strings. If that reason is still valid we should revert to the
Georg> old code, and use

Georg> sendDispatchMessage(translateIfPossible(getMessage()), cmd);

Georg> if getMessage() can contain translated stuff.

The idea was to be able to return untranslated strings to the
lyxserver so that they could be acted on (for example error messages). 

I'd propose to restore things as they were, and keep the decision
about what the best design is for later.

JMarc

Reply via email to