Re: Finish selection? (persistent selection)

[Bo Peng]

Georg:

I need your help on this one for the persistent selection patch.

Thanks.
Bo

On 1/30/07, Bo Peng <[EMAIL PROTECTED]> wrote:

Hi, Georg,

In your preliminary persistent selection patch, you have:

@@ -1042,10 +1042,12 @@ void LyXText::dispatch(LCursor & cur, Fu
                if (cmd.button() == mouse_button::button2)
                        break;

-               // finish selection
                if (cmd.button() == mouse_button::button1) {
-                       if (cur.selection())
-                               theSelection().haveSelection(true);
+                       // finish selection
+                       LCursor & bvcur = cur.bv().cursor();
+                       bvcur.setCursor(cur);
+                       bvcur.selection() = true;
+                       cap::finishSelection(bvcur);
                        needsUpdate = false;
                        cur.noUpdate();
                }

Could you explain in a bit more detail in which sense cur is not yet
completed and what exactly this bvcur is doing? I notice that without
this part, finishSelection saves '' so this is indeed needed. However,
it breaks double-click word selection because the cursor is set in the
middle of the word after the whole word is selected.

Thanks.
Bo