José Matos wrote:
On Tuesday 17 April 2007 10:02:27 am Abdelrazak Younes wrote:
Sorry but we cannot wait for Jose to approve all patches. No offence
Jose but you obviously don't have the time to do so.

Clearly we have a problem of communication here. :-)

The idea of showing the code is not to have my OK for every single patch, that would be mad and it does not fit my idea of release manager.

What I am trying to achieve is peer-review, loosely following the linux model (I don't claim to be like Linus) where there are trusted lieutenants for some parts of the code.

Oh please, can I be your lieutenant? just kidding :-)

That is why I insist in the two OK from certain developers before committing code that is more controversial.

I agree for controversial code. And this is the reason why for example I didn't push strongly for Edwin's toolbar work (although I am OK with it). But for bug fixing patches, I don't think we need to wait for two OKs (that's what I thought Georg was suggesting). OK, the delimiters stuff was at the edge between "bug fixing" and "new-feature" but there were real usability issues which are solved now.


If for some reason this fails I don't have any problem taking the final word, but most of the time this is moot.

Although I don't post to the list on a daily basis I read it and mark the threads that need my attention, that is why I have 7 marked messages in this folder (right now) that are waiting my reply. If I see that some kind of consensus is reached then I ignore the thread and I consider it read.

My main effort has been to avoid that any message to this list is not answered in a reasonable time. It is true that I don't have as much time as I would like to this task but at the same time the coordination is my main role as release manager, at least it this my understanding.

What am I missing?

Nothing, I guess we are in full agreement then :-)

Abdel.


Reply via email to