Andre Poenitz wrote:
On Fri, Apr 27, 2007 at 11:05:06PM -0500, Bo Peng wrote:
You can have a look at my 'rename summary' post. I think a few more
files need to be renamed.
I propose to rename class InsetOld to Inset, and rename as follows.
The idea is to remove 'InsetOld' entrirely be moving stuff either up
and down in the inset hierarchy. This is not 1.5.0 business anymore.
Note that I've done some cleanup in there recently. There's not a lot
remaining:
void setInsetName(docstring const & s) { name_ = s; }
virtual docstring const & getInsetName() const { return name_; }
void setPosCache(PainterInfo const &, int, int) const;
setPosCache() is also implemented in InsetMathDim which is inherited by
most of the math insets; basically all except for InsetMathChar and
InsetMathSymbol. I've (in my local tree) transferred setPosCache() to
InsetBase for a week now and I didn't see any problem with that.
Actually I am almost sure that this is the right thing to do. Doing that
means that we can delete InsetMathDim and that all that will remain in
InsetOld is set/getInsetName().
What do you think?
Abdel.
