Andre Poenitz wrote:
On Fri, May 11, 2007 at 01:12:14AM +0200, Uwe Stöhr wrote:
-       }
-       return lang_pack;
+       } else
+               return lang_pack;
 }

Everytime I see
        if (...) {
                ...
        } else
                return ...;

I get the feeling that it'd better changed to

if (!...) return ...;
        ...

Agreed. In general, it is always better to return early if there's not much to do.

Abdel.

Reply via email to