Dov Feldstern wrote:
Elazar Leibovich wrote:
The attached patch disable Paragraph::getUChar functionality of
inversing the paranthesis. I grep'ed for the function and it seems to
be used only by math inset's pasting getPlainText mechanism, and
indeed it has no effect on regular paranthesis.
Please have a look at this very simple patch and apply it if possible.
If you're convinced the parenthesis inversion is unnecessary, feel
free to remove it altogether.
Thanks
Hi Elazar ---
I'm taking a look at your pacth, but I just want to understand what
exactly we're talking about. Could you elaborate a bit on the bug this
is meant to fix: where are you copying from? Where are you pasting to
(*into* a math inset?)?
Thanks!
Dov
Also:
*) I don't see any function named getPlainText --- where is it?
*) getUChar appears to be used in output_plaintext.cpp --- and indeed,
your patch affects the plaintext output of a Hebrew document.
*) there are two functions which exist: getChar and getUChar --- the
sole difference between them being that getUChar reverses parentheses
--- so I don't think that we want to get rid of that! If you think
there's a place that getUChar is being used, and parentheses should not
be reversed, then perhaps we could use getChar there instead?
Finally, I just want to point out that as far as I know, the issue of
parentheses in RTL is complicated, and I'm not sure that there is one
correct standard --- I think different programs (perhaps also different
platforms) have different conventions for dealing with this. So I would
be careful about tampering with this.
Again, I'd like to here about the exact situation in which this bug
occurs, but chances are that I will claim that it's just an issue of no
clear standard existing...
Dov
