On Tue, May 22, 2007 at 11:31:32AM -0500, Bo Peng wrote:
> On 5/22/07, Jürgen Spitzmüller <[EMAIL PROTECTED]> wrote:
> >The attached patch makes the internal messages translatable. Please have a
> >look at the conversion business. I'm not entirely sure I got it right.
>
> I do not know these from/to/utf8/docstring stuff so I will not
> comment. Attached is a slightly modified patch that fixes a few typos,
> comments etc.
>
> Bo
> Index: src/insets/InsetListingsParams.h
> ===================================================================
> --- src/insets/InsetListingsParams.h (revision 18451)
> +++ src/insets/InsetListingsParams.h (working copy)
> @@ -93,8 +93,8 @@
>
> class invalidParam : public std::exception {
> public:
> - invalidParam(std::string const & details) :
> - details_(details)
> + invalidParam(docstring const & details) :
> + details_(to_utf8(details))
> {}
class InvalidParam : public std::exception {
public:
InvalidParam(docstring const & details)
: details_(to_utf8(details))
{}
> @@ -52,7 +53,7 @@
> char const * name;
> /// default value
> char const * value;
> - // for option with value "true", "false",
> + // for option with value "true", "false",
Good.
Rest looks good.
Andre'
