Am 27.05.2007 um 02:24 schrieb Dov Feldstern:
My only comment regarding the code itself: I would suggest separating the fix for bug 3720 from the rest of the patch here, and applying them separately. They are not logically interdependent (the fix for bug 3720 could be applied independently of the bigger change being made here), so conceptually it's better, I think, to separate them; and the practical implication is that if for some reason someone will want to revert your patch (say some major bug is discovered just before the rc1 release), then that fix will also get reverted by accident, which it needn't. Attached find the separated patches: cursor_left_inset.diff fixes bug 3720, and cursordispatch_no_corsur_left_inset.diff is all the rest (meant to be applied *after* the previous one). Together, they are exactly equivalent to your patch.
Thanks for pointing that out. Committed the fix for 3720 now (taken the OKs from the other thread talking about exactly this part of the patch)
Stefan
PGP.sig
Description: Signierter Teil der Nachricht
