Dov Feldstern wrote:
Stefan Schimanski wrote:

I have fixed the logic now in my patch to equal that of LyX 1.4 exactly (see attached).


I think this is one step too far. There were bugs with the 1.4 logic that were causing a crash, that's what I fixed a couple of weeks ago (r18389). I think you copied the bug this time --- I'm getting a crash again. (On the second half of a paragraph split across multiple lines, start moving backwards, with the RTL option on.)

The previous version of your patch (from 23:01) was good, I think. Except that perhaps some of the conditions in cursorLeft and cursorRight are unnecessary, but I don't think they hurt...


(Anyhow, I'm already building upon that version --- see http://permalink.gmane.org/gmane.editors.lyx.devel/85603 ;) --- But seriously, the fact that other bugs can be fixed based upon your changes is another indication that they are correct.)

Dov



Reply via email to