Re: [patch] Language of Inset (bug 3011)

[Dov Feldstern]

Dov Feldstern wrote:

Jean-Marc Lasgouttes wrote:

"Dov" == Dov Feldstern <[EMAIL PROTECTED]> writes:

Dov> Hi! attached find a very simple fix for
Dov> http://bugzilla.lyx.org/show_bug.cgi?id=3011 (which is a
Dov> regression relative to 1.3.X). The problem is that when typing
Dov> some LTR in an RTL paragraph (or vice versa), when an inset is
Dov> inserted, it gets inserted in the paragraph language, and not in
Dov> the current language. It's more correct for the inset to be
Dov> inserted in the current language. That's what this patch
Dov> achieves.

Is there a reason why you use real_current_font instead of
current_font? The later is the non-expanded version, which is IMO
better.

Attached is the patch using current_font. Is this Okay?

Dov

Index: lyx-devel/src/Text2.cpp
===================================================================
--- lyx-devel.orig/src/Text2.cpp        2007-06-14 23:46:30.000000000 +0300
+++ lyx-devel/src/Text2.cpp     2007-06-14 23:48:16.000000000 +0300
@@ -670,7 +670,7 @@
 {
        BOOST_ASSERT(this == cur.text());
        BOOST_ASSERT(inset);
-       cur.paragraph().insertInset(cur.pos(), inset,
+       cur.paragraph().insertInset(cur.pos(), inset, current_font,
                                    Change(cur.buffer().params().trackChanges ?
                                           Change::INSERTED : 
Change::UNCHANGED));
 }