The attached simple patch fixes the following:

- Open the listings dialog and type in some unknown command: OK button is 
greyed out (correct)
- now click "pass validation": OK button is activated (correct)
- uncheck "pass validation" again: OK button still activated (wrong).

Same for Document and Include dialogs.

OK to go in?

Jürgen
Index: src/frontends/qt4/QDocument.cpp
===================================================================
--- src/frontends/qt4/QDocument.cpp	(Revision 18888)
+++ src/frontends/qt4/QDocument.cpp	(Arbeitskopie)
@@ -224,6 +224,8 @@
 		this, SLOT(change_adaptor()));
 	connect(textLayoutModule->bypassCB, SIGNAL(clicked()), 
 		this, SLOT(change_adaptor()));
+	connect(textLayoutModule->bypassCB, SIGNAL(clicked()), 
+		this, SLOT(validate_listings_params()));
 	connect(textLayoutModule->listingsED, SIGNAL(textChanged()),
 		this, SLOT(validate_listings_params()));
 	textLayoutModule->listingsTB->setPlainText(
Index: src/frontends/qt4/QInclude.cpp
===================================================================
--- src/frontends/qt4/QInclude.cpp	(Revision 18888)
+++ src/frontends/qt4/QInclude.cpp	(Arbeitskopie)
@@ -67,6 +67,7 @@
 	connect(listingsED, SIGNAL(textChanged()), this, SLOT(change_adaptor()));
 	connect(listingsED, SIGNAL(textChanged()), this, SLOT(validate_listings_params()));
 	connect(bypassCB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
+	connect(bypassCB, SIGNAL(clicked()), this, SLOT(validate_listings_params()));
 
 	filenameED->setValidator(new PathValidator(true, filenameED));
 	setFocusProxy(filenameED);
Index: src/frontends/qt4/QListings.cpp
===================================================================
--- src/frontends/qt4/QListings.cpp	(Revision 18888)
+++ src/frontends/qt4/QListings.cpp	(Arbeitskopie)
@@ -192,6 +192,7 @@
 	connect(listingsED,  SIGNAL(textChanged()), this, SLOT(change_adaptor()));
 	connect(listingsED,  SIGNAL(textChanged()), this, SLOT(validate_listings_params()));
 	connect(bypassCB, SIGNAL(clicked()), this, SLOT(change_adaptor()));
+	connect(bypassCB, SIGNAL(clicked()), this, SLOT(validate_listings_params()));
 
 	for (int n = 0; languages[n][0]; ++n)
 		languageCO->addItem(qt_(languages_gui[n]));

Reply via email to