On Mon, Jul 02, 2007 at 01:26:34AM +0300, Dov Feldstern wrote:
> Hi!
>
> Attached find a patch fixing
> http://bugzilla.lyx.org/show_bug.cgi?id=3959 (which I just opened tonight).
>
> Please note that there appears to have been an attempt to explicitly do
> the opposite of what I'm trying to do here, though for different
> reasons, I think: r10808, which fixed bug 2115. I'm not sure if what I'm
> trying to fix here is a necessary consequence of that fix, but I
> certainly consider the current behavior which the current patch fixes
> buggy.
>
> Martin, Helge --- is the current patch OK with you?
I remember fighting with this, and (1) don't understand this stuff enough
to comment one way or the other, and (2) I don't really think your current
patch and 2115 are related or in comflict.
> Specifically, what I'm doing here is going to override what's being done
> in the InsetText constructor; but I'm not getting rid of that, because
> there still may be times when the constructor is called, from elsewhere...
>
> My patch still doesn't handle Tables. I think the language of tables
> should be set to the current language, as well. Any help is welcome.
>
> Thanks!
> Dov
- Martin
> Index: lyx-devel/src/Paragraph.cpp
> ===================================================================
> --- lyx-devel.orig/src/Paragraph.cpp 2007-07-02 00:28:16.000000000 +0300
> +++ lyx-devel/src/Paragraph.cpp 2007-07-02 00:50:38.000000000 +0300
> @@ -1254,7 +1254,13 @@
> Font const & font, Change const & change)
> {
> pimpl_->insertInset(pos, inset, change);
> + // Set the font/language of the inset...
> setFont(pos, font);
> + // ... as well as the font/language of the text inside the inset
> + if (inset->asTextInset()) {
> + inset->asTextInset()->text_.current_font = font;
> + inset->asTextInset()->text_.real_current_font = font;
> + }
> }
>
>
