Richard Heck wrote: > > The attached patch finishes this bit of work, left over from the > InsetCommand conversion. Comments welcome before I commit. > > Richard
This sort of change gives me a nice, warm, fuzzy feeling. It's obvious you've done something right when you can remove so much code :-) Minor comments: It would be nice to see the death of those to_utf8(...) calls. Shouldn't the enum and the type(InsetCommandParams const &) function live in an anonymous namespace? There's some whitespace horkage in/around the enum definition. -- Angus
