rgheck wrote:


Considering multiview, I'd prefer a solution based on signal/slot. Maybe static signal member in InsetLabel? See attached, untested.

OK. I wasn't thinking that the different views had different BufferList's.

No, the BufferList is common, it's just that mutiple views might have one GuiRef each.

In any event, the SignalSlot machinery seems to be unused at present, so I can't find an example of its use. But the moment I try to use it, I get linking errors. It's enough to add this:
   static Signal modified;
   ~InsetLabel() { modified.fire()
to InsetLabel.h (with the #include, of course), and then:

You forgot to declare the static member somewhere (in InsetLabel.cpp in my original patch):

Index: InsetLabel.cpp
===================================================================
--- InsetLabel.cpp      (revision 22331)
+++ InsetLabel.cpp      (working copy)
@@ -27,10 +27,13 @@

 namespace lyx {

+Signal InsetLabel::modified;


Removing the "static" keyword doesn't help (not that we'd want to do that). I'm not sure what's wrong here.

The whole patch causing this issue is below.

The slot in GuiRef does not need to be static AFAICS.

Abdel.

Reply via email to