Abdelrazak Younes <[EMAIL PROTECTED]> writes: > I guess 'not bad' means good here ;-)
Yes. > Algorithms are algorithms, why do you want to recreate them? FWIW, > I've created the TocModel class for Navigation purpose and it uses > approximatively the same algorithm as in expandToc()/expandToc2(), yet > the code is smaller and more understandable IMO. I do not say that expandToc/expandToc2 are a model of good coding. But they are more complicated, since the number of submenus is decided dynamically depending on their complexity (i.e. subsections are not in a submenu if not needed). I am not sure that it is necessary to retain the same algorithm, but at least the general idea is sound IMO. > JMarc, as I said, if you're too negative about that, I won't do > anything. I understand that this is one of your first big contribution > to the code. Sorry if I was unclear: I am not complaining that it is not going to work, just pointing a few things. I do not want to sound too negative before you do it. The part of the code that is annoying (navigate menu) is not mine, it is the work of Dekel Tsur. My contribution was just the separation of the menu code to the interface. I am not going to lose appetite if the code goes back to the frontend but I tend to think the main benefit you see is that you will feel at home with this code :) I stop annoying you now. JMarc
