JMarc> Angus> Attached is a small patch that moves the "moving around the
JMarc> Angus> document" functionality out of the xforms-specific dialog and
JMarc> Angus> into a new BufferView::Dispatch() method where it belongs. This
JMarc> Angus> method will eventually also govern other "moving around the
JMarc> Angus> document" behaviour, (eg for InsetRef and the reference-insert
JMarc> Angus> dialog).
JMarc> I do not like this one, since all lyxfuncs should take arguments which
JMarc> are expressed as strings. Here you create an action which does not
JMarc> have the correct semantics and is not routed via the normal path. If
JMarc> you really want to move the code around, it should not be an action
JMarc> like that.
Well then, we have three choices.
1. We keep the code as it was, with the "move around the ducument"
functionality in the dialog. As I understand it, this is contrary to the "keep
functionality out of the dialogs and in the kernel" approach that I've had
thrown at me in the past.
2. I can try and convince you that this "all lyxfuncs should take arguments which
are expressed as strings" argument is self-imposed rubbish. In this case we
have a LyXParagraph pointer to hand and LyXText::SetCursor() requires just
that. If we were using xtl, then I could obviously convert the pointer to a
string and extract it in Dispatch, but we're not so this restriction is clearly
daft IMO.
3. You can give me a suggestion on "best practice" or "how to proceed" because
I confess myself thick/unimaginative/pissed off!
Right. I've recovered my sense of humour. It is Friday after all (fairly big
grin here ;-).
Angus
